nylas · arunagw · Aug 22, 2019 · Aug 21, 2019 · Aug 21, 2019 · Aug 22, 2019
diff --git a/lib/nylas.rb b/lib/nylas.rb
@@ -61,6 +61,7 @@
 require_relative "nylas/http_client"
 require_relative "nylas/api"
 
+require_relative "nylas/filter_attributes"
 # an SDK for interacting with the Nylas API
 # @see https://docs.nylas.com/reference
 module Nylas

diff --git a/lib/nylas/filter_attributes.rb b/lib/nylas/filter_attributes.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Nylas
+  # Methods to check and raise error if extra attributes are present
+  class FilterAttributes
+    def initialize(attributes:, allowed_attributes:)
+      @attributes = attributes
+      @allowed_attributes = allowed_attributes
+    end
+
+    def check
+      return if extra_attributes.empty?
+
+      raise ArgumentError, "Only #{allowed_attributes} are allowed to be sent"
+    end
+
+    private
+
+    attr_reader :attributes, :allowed_attributes
+
+    def extra_attributes
+      attributes - allowed_attributes
+    end
+  end
+end
diff --git a/lib/nylas/message.rb b/lib/nylas/message.rb
@@ -8,6 +8,7 @@ class Message
     self.raw_mime_type = "message/rfc822"
     self.resources_path = "/messages"
     allows_operations(showable: true, listable: true, filterable: true, searchable: true, updatable: true)
+    UPDATABLE_ATTRIBUTES = %i[label_ids folder_id starred unread].freeze
 
     attribute :id, :string
     attribute :object, :string
@@ -34,7 +35,10 @@ class Message
     has_n_of_attribute :events, :event
     has_n_of_attribute :files, :file
     attribute :folder, :folder
+    attribute :folder_id, :string
+
     has_n_of_attribute :labels, :label
+    has_n_of_attribute :label_ids, :string
 
     transfer :api, to: %i[events files folder labels]
 
@@ -46,6 +50,15 @@ def unread?
       unread
     end
 
+    def update(payload)
+      FilterAttributes.new(
+        attributes: payload.keys,
+        allowed_attributes: UPDATABLE_ATTRIBUTES
+      ).check
+
+      super(payload)
+    end
+
     def expanded
       return self unless headers.nil?
 

diff --git a/spec/nylas/filter_attributes_spec.rb b/spec/nylas/filter_attributes_spec.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+describe Nylas::FilterAttributes do
+  describe "#check" do
+    context "when `attributes` and `allowed_attributes` are similar" do
+      it "does not raise any error" do
+        attributes = %i[foo bar]
+        allowed_attributes = %i[foo bar]
+        filter = described_class.new(attributes: attributes, allowed_attributes: allowed_attributes)
+
+        expect { filter.check }.not_to raise_error
+      end
+    end
+
+    context "when `attributes` and `allowed_attributes` are different" do
+      it "raises an error" do
+        attributes = %i[foo bar]
+        allowed_attributes = %i[foo]
+        filter = described_class.new(attributes: attributes, allowed_attributes: allowed_attributes)
+
+        expect { filter.check }.to raise_error(ArgumentError, "Only [:foo] are allowed to be sent")
+      end
+    end
+  end
+end
diff --git a/spec/nylas/message_spec.rb b/spec/nylas/message_spec.rb
@@ -122,6 +122,40 @@
     end
   end
 
+  describe "#update" do
+    it "let's you set the starred, unread, folder, and label ids" do
+      api = instance_double(Nylas::API, execute: "{}")
+      message = described_class.from_json('{ "id": "message-1234" }', api: api)
+
+      message.update(
+        starred: true,
+        unread: false,
+        folder_id: "folder-1234",
+        label_ids: %w[label-1234 label-4567]
+      )
+
+      expect(api).to have_received(:execute).with(
+        method: :put, path: "/messages/message-1234",
+        payload: JSON.dump(
+          starred: true, unread: false,
+          folder_id: "folder-1234",
+          label_ids: %w[
+            label-1234
+            label-4567
+          ]
+        )
+      )
+    end
+
+    it "raises an argument error if the data has any keys that aren't allowed to be updated" do
+      api = instance_double(Nylas::API, execute: "{}")
+      message = described_class.from_json('{ "id": "message-1234" }', api: api)
+      expect do
+        message.update(subject: "A new subject!")
+      end.to raise_error ArgumentError, "Only #{described_class::UPDATABLE_ATTRIBUTES} are allowed to be sent"
+    end
+  end
+
   describe "#expanded" do
     it "fetch or return expanded version of message" do
       api = instance_double(Nylas::API, execute: "{}")