fix(core): make eslint optional dependency

nx-dotnet · Jan 31, 2023 · 43eee12 · 43eee12
1 parent f8be153
commit 43eee12
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -11,7 +11,13 @@
   "peerDependencies": {
     "@nrwl/devkit": ">14.0.0-beta.1",
     "@nrwl/workspace": ">14.0.0-beta.1",
-    "nx": ">14.0.0-beta.1"
+    "nx": ">14.0.0-beta.1",
+    "eslint": ">8.0.0"
+  },
+  "peerDependenciesMeta": {
+    "eslint": {
+      "optional": true
+    }
   },
   "devDependencies": {
     "@nrwl/cli": "*"

diff --git a/packages/core/src/tasks/check-module-boundaries.ts b/packages/core/src/tasks/check-module-boundaries.ts
@@ -6,7 +6,6 @@ import {
   Workspaces,
 } from '@nrwl/devkit';
 
-import { ESLint } from 'eslint';
 import { relative } from 'path';
 
 import {
@@ -69,16 +68,22 @@ export async function loadModuleBoundaries(
 ): Promise<ModuleBoundaries> {
   const configured = readConfig(host).moduleBoundaries;
   if (!configured) {
-    const result = await new ESLint()
-      .calculateConfigForFile(`${root}/non-existant.ts`)
-      .catch(() =>
-        Promise.resolve({
-          rules: { '@nrwl/nx/enforce-module-boundaries': [] },
-        }),
-      );
-    const [, moduleBoundaryConfig] =
-      result.rules['@nrwl/nx/enforce-module-boundaries'] || [];
-    return moduleBoundaryConfig?.depConstraints ?? [];
+    try {
+      // eslint-disable-next-line @typescript-eslint/no-var-requires
+      const { ESLint }: typeof import('eslint') = require('eslint');
+      const result = await new ESLint()
+        .calculateConfigForFile(`${root}/non-existant.ts`)
+        .catch(() =>
+          Promise.resolve({
+            rules: { '@nrwl/nx/enforce-module-boundaries': [] },
+          }),
+        );
+      const [, moduleBoundaryConfig] =
+        result.rules['@nrwl/nx/enforce-module-boundaries'] || [];
+      return moduleBoundaryConfig?.depConstraints ?? [];
+    } catch {
+      return [];
+    }
   } else {
     return configured;
   }