Implemented CatalogImageMissingException in LocalFileImageService

nwolisa · Apr 30, 2017 · 3b1e46d · 3b1e46d
1 parent bc088be
commit 3b1e46d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/src/ApplicationCore/Exceptions/CatalogImageMissingException.cs b/src/ApplicationCore/Exceptions/CatalogImageMissingException.cs
@@ -4,10 +4,15 @@ namespace ApplicationCore.Exceptions
 {
     public class CatalogImageMissingException : Exception
     {
-        public CatalogImageMissingException(string message, 
-            Exception innerException = null) 
+        public CatalogImageMissingException(string message,
+            Exception innerException = null)
             : base(message, innerException: innerException)
         {
         }
+        public CatalogImageMissingException(Exception innerException)
+            : base("No catalog image found for the provided id.", 
+                  innerException: innerException)
+        {
+        }
     }
 }
diff --git a/src/Infrastructure/FileSystem/LocalFileImageService.cs b/src/Infrastructure/FileSystem/LocalFileImageService.cs
@@ -1,4 +1,5 @@
-using ApplicationCore.Interfaces;
+using ApplicationCore.Exceptions;
+using ApplicationCore.Interfaces;
 using Microsoft.AspNetCore.Hosting;
 using System.IO;
 
@@ -14,9 +15,16 @@ public LocalFileImageService(IHostingEnvironment env)
         }
         public byte[] GetImageBytesById(int id)
         {
-            var contentRoot = _env.ContentRootPath + "//Pics";
-            var path = Path.Combine(contentRoot, id + ".png");
-            return File.ReadAllBytes(path);
+            try
+            {
+                var contentRoot = _env.ContentRootPath + "//Pics";
+                var path = Path.Combine(contentRoot, id + ".png");
+                return File.ReadAllBytes(path);
+            }
+            catch (FileNotFoundException ex)
+            {
+                throw new CatalogImageMissingException(ex);
+            }
         }
     }
 }