Improve Morpheus Shutdown Behavior On Exception #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was some outstanding work that was a result of changes in the SRF PR: nv-morpheus/MRC#208.
If an exception is detected, we can try to manually call stop on all stages to allow for better shutdown behavior. Included in this PR are fixes to remove
CMAKE_BUILD_RPATH_USE_ORIGINfrom the CMake file which breaks building SRF with Morpheus at the same time. This option is only needed during the CI build so it was added manually to the CI scripts.