feat: allow multiple nuxt in a single process #30510
Draft
+252
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ starter, example-layers-monorepo, nuxt-com, cli, tailwindcss |
|
ecosystem ci fails due to typecheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
unblocked by nitrojs/nitro#2983 ❤️
fix nuxt/test-utils#537
fix nuxt/test-utils#1034
resolve nuxt/test-utils#664
fix #22565
📚 Description
This PR allows to create multiple Nuxt instance within a single process.
We were previously setting a Nuxt Singleton with unctx. This means that we can only run a single Nuxt instance in a single process.
By using asyncLocalStorage, we'll be able to track an unique id for each
buildNuxtandinitNuxt-> allowing to run these in parallel and alluseNuxt()within it. It also convertnuxtCtxto be a getter so it retrieves the correct namespace withASyncLocalStorageFor backward compatibility, we'll keep a fallback global singleton of the first Nuxt instance that is being set. This behavior will be removed in V4 or V5. We can also add a
.runon the Nuxt instance in Nuxt 4.next step: merge all nuxt test within a single job