Handle permission denied error at nu_engine::glob_from
#14679
Conversation
| ShellError::GenericError { | ||
| error, | ||
| msg, | ||
| span: _, | ||
| help, | ||
| inner, | ||
| } if error.as_str() == "Permission denied" => ShellError::GenericError { | ||
| error, | ||
| msg, | ||
| span: Some(arg_span), | ||
| help, | ||
| inner, | ||
| }, |
There was a problem hiding this comment.
Could you add a comment explaining why this is here? It makes sense in the context of the PR, but I think this might be a bit confusing if you were to stumble across it.
| Ok(p) => p, | ||
| Err(err) => { | ||
| return match err.kind() { | ||
| ErrorKind::PermissionDenied => Err(ShellError::GenericError { |
There was a problem hiding this comment.
I think this should be a ShellError::IOError instead of a ShellError::GenericError; cd uses IOError when you attempt to cd into a directory without permission.
There was a problem hiding this comment.
Since ShellError::IOError doesn't contain an easy reliable way to check which io error is used, I don't like using it. And adding std::io::ErrorKind to ShellError::IOError which would be optimal, kind of explodes the scope here imo.
|
Sorry it takes a long time, would you resolve the conflict first? |
|
Resolved it, let's wait for the pipeline. |
|
Are we ready to land this? |
|
LGTM |
|
Thanks! |
Description
#14528 mentioned that trying to
opena file in a directory where you don't have read access results in a "file not found" error. I investigated the error and could find the root issue in thenu_engine::glob_fromfunction. It usesstd::path::Path::canonicalizesome layers down and that may return anstd::io::Error. All these errors were handled as "directory not found" which will be translated to "file not found" in theopencommand. To fix this, I handled thePermssionDeniederror kind of the io error and passed that down. Now trying toopena file from a directory with no permissions returns a "permission denied" error.Before/After:
User-Facing Changes
That error is fixed, so correct error message.
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
fixes #14528