Rename/deprecate into bits to format bits
#14634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`into bits` is a bad name because it is not a traditional type cast to a `bits` type like all the other `into` commands. Instead it is a pretty printer generating `string` type output. Thus the correct bucket is `format` and its subcommands.
sholderbach
added
pr:breaking-change
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Dec 19, 2024
Stumbled over unnecessary `pub` `fn action` and `struct Arguments` when reworking `into bits` in nushell#14634 Stuff like this should be local until proven otherwise and then named approrpiately.
sholderbach
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
into bitsis a bad name because it is not a traditional type cast to abitstype like all the otherintocommands.Instead it is a pretty printer generating
stringtype output. Thus thecorrect bucket is
formatand its subcommands.User-Facing Changes
into bitswill raise aDeprecatedWarningsuggesting the move toformat bitsinto bitscan be removed in0.103.0Tests + Formatting
All tests that relied on
into bitshave been updated toformat bits