[Nathaniel Lukas] iP #477

dreammac3816547290 · 2022-08-27T01:45:35Z

Duke

"The shorter way to do many things is to only do one thing at a time." - Mozart

Duke helps you keep track of ToDo, Event, and Deadline tasks. It's

TEXT-BASED
simple
powerful

All you need to do is

download the duke.jar file from here.
open the command prompt and navigate to the location of the downloaded file.
type java -jar duke.jar and enter.
use it however you want! 😃

Features:

Add ToDos, Deadlines, and Events.
List all tasks.
Delete tasks.
Mark tasks as done or not done.

If you are a Java programmer, you can use it to practice Java too. Here's the main method

public static void main(String[] args) {
    new Duke().start();
}

…ot done.

…ng of Duke.

…changes. Load the data from the hard disk when the project starts up.

…bjects. Accept dates in yyyy-mm-dd format and print in MMM dd yyyy format

lpohsien

Overall, I found the code easy to follow. The coding standard was consistent with only a few nits that might need fixing. Descriptive headers for public classes and methods could be included to allow for better documentation.

lpohsien · 2022-08-30T09:24:53Z

src/main/java/Task.java

+        isDone = false;
+    }
+
+    public String data() {


Perhaps the name for the method could be change to one that starts with a verb like convertToData?

lpohsien · 2022-08-30T09:26:26Z

src/main/java/Task.java

@@ -0,0 +1,32 @@
+public class Task {


Perhaps this Task class and it's derived class could be put into a single package?

lpohsien · 2022-08-30T09:36:32Z

src/main/java/Task.java

+        type = 'T';
+    }
+
+    public String getStatusIcon() {


Maybe you can add some method headers for the public methods?

lpohsien · 2022-08-30T09:43:46Z

src/main/java/Duke.java

+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } else if (s.equals("deadline")) {
+                    String rest = sc.nextLine();
+                    String[] split = rest.split("/");


Considering that the split is an array of strings, perhaps it could named using the plural convention? Another way to name it could be tokens which might be more informative?

Tan-Jin-Waye

Code employed is sufficient to pass muster for Level 7/8, but better design choices need to be applied for later levels. I assume you're busy with other commitments at the moment, in which case all the best.

Jiayous.

Tan-Jin-Waye · 2022-09-01T13:49:22Z

src/main/java/Duke.java

+                if (s.equals("bye")) {
+                    System.out.println("Bye. Hope to see you again soon!");
+                    break;
+                } else if (s.equals("list")) {
+                    System.out.println("Here are the tasks in your list:");
+                    for (int a = 0; a < tasks.size(); a++) {
+                        System.out.println((a + 1) + "." + tasks.get(a));
+                    }
+                    sc.nextLine();
+                } else if (s.equals("mark")) {
+                    int index = sc.nextInt() - 1;
+                    if (index >= tasks.size()) {
+                        throw new DukeException("Index out of bound!");
+                    }
+                    tasks.get(index).markAsDone();
+                    System.out.println("Nice! I've marked this task as done:");
+                    System.out.println(tasks.get(index));
+                    sc.nextLine();
+                } else if (s.equals("unmark")) {
+                    int index = sc.nextInt() - 1;
+                    if (index >= tasks.size()) {
+                        throw new DukeException("Index out of bound!");
+                    }
+                    tasks.get(index).markNotDone();
+                    System.out.println("OK, I've marked this task as not done yet:");
+                    System.out.println(tasks.get(index));
+                    sc.nextLine();
+                } else if (s.equals("todo")) {
+                    String task = sc.nextLine();
+                    if (task.trim().isEmpty()) {
+                        throw new DukeException("☹ OOPS!!! The description of a todo cannot be empty.");
+                    }
+                    tasks.add(new Task(task));
+                    System.out.println("Got it. I've added this task:");
+                    System.out.println(tasks.get(tasks.size() - 1));
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } else if (s.equals("deadline")) {
+                    String rest = sc.nextLine();
+                    String[] split = rest.split("/");
+                    String task = split[0];
+                    String deadline = split[1];
+                    deadline = deadline.substring(deadline.indexOf(' ') + 1);
+                    tasks.add(new Deadline(task, deadline));
+                    System.out.println("Got it. I've added this task:");
+                    System.out.println(tasks.get(tasks.size() - 1));
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } else if (s.equals("event")) {
+                    String rest = sc.nextLine();
+                    String[] split = rest.split("/");
+                    String task = split[0];
+                    String time = split[1];
+                    time = time.substring(time.indexOf(' ') + 1);
+                    tasks.add(new Event(task, time));
+                    System.out.println("Got it. I've added this task:");
+                    System.out.println(tasks.get(tasks.size() - 1));
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } else if (s.equals("delete")) {
+                    int index = sc.nextInt() - 1;
+                    if (index >= tasks.size()) {
+                        throw new DukeException("Index out of bound!");
+                    }
+                    tasks.remove(index);
+                    System.out.println("Noted. I've removed this task:");
+                    System.out.println(tasks.get(index));
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                    sc.nextLine();
+                } else {
+                    String rest = sc.nextLine();
+                    throw new DukeException("☹ OOPS!!! I'm sorry, but I don't know what that means :-(");
+                }
+                modify(tasks);
+            } catch (DukeException e) {
+                System.out.println(e.getMessage());
+            }
+        }


Do consider the use of a switch statement as opposed to a large if-else block.

switch (s) { case "bye": // Code for exit break; case "list": // Code for list print break; ...

Tan-Jin-Waye · 2022-09-01T13:56:39Z

src/main/java/Duke.java

+            if (split[0].equals("T")) {
+                tasks.add(new Task(split[2]));
+                if (split[1].equals("1")) {
+                    tasks.get(tasks.size() - 1).markAsDone();
+                }
+            } else if (split[0].equals("D")) {
+                tasks.add(new Deadline(split[2], split[3]));
+                if (split[1].equals("1")) {
+                    tasks.get(tasks.size() - 1).markAsDone();
+                }
+            } else if (split[0].equals("E")) {
+                tasks.add(new Event(split[2], split[3]));
+                if (split[1].equals("1")) {
+                    tasks.get(tasks.size() - 1).markAsDone();
+                }


Again, consider using a switch statement.
A switch fallthrough can be used to deal with the Deadline (line 115) and Event (line 120) cases elegantly.

switch (split[0]) { case "T": // Code for Todo break; case "D": // Fallthrough case "E": // Code for Deadline and Event break;

Tan-Jin-Waye · 2022-09-01T14:01:29Z

src/main/java/Task.java

+    protected String description;
+    protected boolean isDone;
+    protected char type;


Nice use of protected, though realistically not necessary for description and isDone.

Tan-Jin-Waye · 2022-09-01T14:07:45Z

src/main/java/Task.java

+    public void markAsDone() {
+        isDone = true;
+    }
+
+    public void markNotDone() {
+        isDone = false;


May want to include some code to check if the user is attempting to markAsDone an already done task, and same for markNotDone, and respond to user accordingly.

…tandard

…vel-9

… at various points in the code There are no checks to ensure the correctness of each aspect of the program (e.g. variable values at certain points in time). It allows some bugs to be left undetected until an Exception happens and theprogram is terminated. Adding assertions into the program acts as a sanity check and helps in ensuring the correctness of the program.

Use assert feature to document important assumptions that should hold…

…ssary Important exceptions were not thrown, causing the program to terminate when bugs occur. Exceptions need to be thrown and catch to ensure the code works as intended and to eliminate bugs. Important exceptions are thrown and catch, and the error message is displayed in Duke GUI, especially for exceptions regarding array out of bound and incorrect syntax.

…ut task

Examines the code and refactor to improve the code quality where nece…

Provide a way for the user to find free times, the nearest date witho…

…ally

dreammac3816547290 added 11 commits August 18, 2022 14:47

Skeletal version of Duke

c0c217d

Add the ability to store text entered by the user

1adc1f4

Add the ability to mark tasks as done and change the status back to n…

92577e8

…ot done.

Add support for tracking ToDos, Deadlines, and Events

d0db35f

Use the input/output redirection technique to semi-automate the testi…

e6afc93

…ng of Duke.

Handle errors such as incorrect inputs entered by the user.

248aa72

Add support for deleting tasks from the list.

09a9ccd

Save the tasks in the hard disk automatically whenever the task list …

4418b59

…changes. Load the data from the hard disk when the project starts up.

Store deadline and event dates as a java.time.LocalDate in the task o…

fb0a521

…bjects. Accept dates in yyyy-mm-dd format and print in MMM dd yyyy format

Merge branch 'branch-level-7'

06fa2e7

Merge branch 'branch-level-8'

e64cfc6

lpohsien reviewed Aug 30, 2022

View reviewed changes

Tan-Jin-Waye reviewed Sep 1, 2022

View reviewed changes

dreammac3816547290 and others added 17 commits September 16, 2022 16:36

Extract Ui, Storage, Parser, TaskList, and Command into Classes

c66d9a4

Organize the classes into suitable java packages.

d31c733

Use Gradle to automate some of the build tasks of the project.

96fc62c

Add JUnit tests to test the behavior of the code.

f8cbd0f

Add JavaDoc comments to the code.

92cedc7

Tweak the code to comply with a given coding standard

febe0f6

Give users a way to find a task by searching for a keyword

2d794ce

Resolved merge conflict between branch-A-JavaDoc and branch-A-CodingS…

5f3bbf9

…tandard

Resolved merge conflict between branch-A-CodingStandard and branch-le…

337e3d9

…vel-9

Use checkStyle to detect coding style violations

d7e4287

Add a GUI to Duke with JavaFX technology

97d8588

Merge pull request #2 from dreammac3816547290/branch-A-Assertions

c42cbc0

Use assert feature to document important assumptions that should hold…

Provide a way for the user to find free times, the nearest date witho…

7d08743

…ut task

Merge pull request #3 from dreammac3816547290/branch-A-CodeQuality

392fb2b

Examines the code and refactor to improve the code quality where nece…

Merge branch 'master' into branch-B-FindFreeTimes

bafde2c

dreammac3816547290 and others added 8 commits September 18, 2022 22:58

Merge pull request #4 from dreammac3816547290/branch-B-FindFreeTimes

3327cd3

Provide a way for the user to find free times, the nearest date witho…

Fixed merge mistakes

fae9734

Add JUnit tests, to test nearly all code that can be tested automatic…

9c2e341

…ally

Add screenshot of Duke and add missing tag 'A-FullCommitMessage'

a7e3d6d

Add a User Guide to the project in docs/README.md

8e161f2

Replaced the README.md in the root directory

1a1ce2e

Fixed image link in README.md

fd670dd

Fixed build issue with gradle and modified Storage path

3d93284

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Nathaniel Lukas] iP #477

[Nathaniel Lukas] iP #477

dreammac3816547290 commented Aug 27, 2022 •

edited

Loading

lpohsien left a comment

lpohsien Aug 30, 2022

lpohsien Aug 30, 2022

lpohsien Aug 30, 2022

lpohsien Aug 30, 2022

Tan-Jin-Waye left a comment •

edited

Loading

Tan-Jin-Waye Sep 1, 2022

Tan-Jin-Waye Sep 1, 2022 •

edited by damithc

Loading

Tan-Jin-Waye Sep 1, 2022

Tan-Jin-Waye Sep 1, 2022

[Nathaniel Lukas] iP #477

Are you sure you want to change the base?

[Nathaniel Lukas] iP #477

Conversation

dreammac3816547290 commented Aug 27, 2022 • edited Loading

Duke

lpohsien left a comment

Choose a reason for hiding this comment

lpohsien Aug 30, 2022

Choose a reason for hiding this comment

lpohsien Aug 30, 2022

Choose a reason for hiding this comment

lpohsien Aug 30, 2022

Choose a reason for hiding this comment

lpohsien Aug 30, 2022

Choose a reason for hiding this comment

Tan-Jin-Waye left a comment • edited Loading

Choose a reason for hiding this comment

Tan-Jin-Waye Sep 1, 2022

Choose a reason for hiding this comment

Tan-Jin-Waye Sep 1, 2022 • edited by damithc Loading

Choose a reason for hiding this comment

Tan-Jin-Waye Sep 1, 2022

Choose a reason for hiding this comment

Tan-Jin-Waye Sep 1, 2022

Choose a reason for hiding this comment

dreammac3816547290 commented Aug 27, 2022 •

edited

Loading

Tan-Jin-Waye left a comment •

edited

Loading

Tan-Jin-Waye Sep 1, 2022 •

edited by damithc

Loading