MAINT: Start applying ruff/Pyflakes rules (F) #27309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F822 Undefined name in `__all__`
DimitriPapadopoulos
force-pushed
the
F
branch
3 times, most recently
from
528da5e to
dcc1d0d
Compare
F841 Local variable is assigned to but never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #24994.
The purpose of this PR is to show the kind of changes involved by
Frules, because ruff enablesFrules by default.The idea is not necessarily to apply these rules. Rather I would like to start a discussion whether it we should apply or disable these
Frules, if pycodestyle was replaced by ruff.