MAINT: add a 'tests' install tag to the numpy._core._simd extension module
#26968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module This avoids installing `_simd.so` when the 'tests' install tag is omitted in order to strip the whole test suite. This is a significant saving in binary size especially on x86-64 (see issue 25737, about 10% of the installed size). Tested on macOS arm64 too, there `_simd.so` is 363 kb for a release build, or ~12% of the size of the main extension module (`_multiarray_umath.so`).
|
Thanks @rgommers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids installing
_simd.sowhen the 'tests' install tag is omitted in order to strip the whole test suite.This is a significant saving in binary size especially on x86-64 (see gh-25737, about 10% of the installed size).
Tested on macOS arm64 too, there
_simd.sois 363 kb for a release build, or ~12% of the size of the main extension module (_multiarray_umath.so).