Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update a few interpreted text to verbatim/code. #25501

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 26, 2023

Single backticks are meant to reference another object and sphinx/docutils is trying to fond those.

In the current sphinx theme those are rendered in italic.

For all those I assume what was meant is actually code, or verbatim.

Single backticks are meant to reference another object and
sphinx/docutils is trying to fond those.

In the current sphinx theme those are rendered in italic.

For all those I assume what was meant is actually code, or verbatim.
Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look correct to me and CI failure appears unrelated. Commit history looks good so I'll regular-merge.

@Carreau what do you think of my suggestions to clarify this in the numpydoc style guide?
numpy/numpydoc@main...mdhaber:numpydoc:backticks
This is part of a larger plan to render references to parameters in monospaced font and eventually as links to the parameter descriptions.

@mdhaber mdhaber merged commit 3d323c0 into numpy:main Dec 26, 2023
63 of 64 checks passed
@mattip
Copy link
Member

mattip commented Dec 27, 2023

Related to #13114. This brings the number of warnings down to 105.

Thanks @Carreau

@Carreau
Copy link
Contributor Author

Carreau commented Dec 27, 2023

@Carreau what do you think of my suggestions to clarify this in the numpydoc style guide?
numpy/numpydoc@main...mdhaber:numpydoc:backticks
This is part of a larger plan to render references to parameters in monospaced font and eventually as links to the parameter descriptions.

Yeah, I think it is good to clarify, but I don't think the problem is clarification, the problem is single and double backticks are too easy to confuse, especially with markdown.

Funny thing, is I also sent thin because I'm working on having reference to parameter rendering differently but not for sphinx.

IMHO a think that would help – nut I'm not sure how to do. Is to have a different style that is potentially quite visible for all sphinx references that have not been resolved. This way it's easy at a glance to a page to tell if there are issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants