Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI | Update Admission Tests Workflow #1063

Merged
merged 1 commit into from
Mar 16, 2023
Merged

CI | Update Admission Tests Workflow #1063

merged 1 commit into from
Mar 16, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Feb 23, 2023

Explain the changes

  1. Remove the comments about open issues that were closed (DB-Dump Not Generated In Test Namespace Using PG DB #1040 and Proposal: Configuration kubernetes/kubernetes#1007).
  2. Add script to wait until we have the backingstore pod (in k8s we cannot wait for a resource that doesn't exist, more information here).
  3. Update core repo to the latest commit.

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. none, will be tested in the workflow.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Feb 23, 2023
@shirady shirady changed the title Update Admission Tests Workflow CI | Update Admission Tests Workflow Feb 23, 2023
@shirady shirady marked this pull request as draft February 23, 2023 14:17
@shirady
Copy link
Contributor Author

shirady commented Feb 23, 2023

I converted it to a draft Pr because the script runs well on my machine and not in the workflow, need to check it.

@shirady shirady marked this pull request as ready for review February 27, 2023 07:28
@shirady shirady force-pushed the update-workflow-admission branch 3 times, most recently from 638aa1a to 11bc4e7 Compare February 28, 2023 09:53
liranmauda
liranmauda requested changes Mar 2, 2023
View reviewed changes
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
number_of_pods_in_system.sh Outdated Show resolved Hide resolved
@shirady
update admission tests workflow
7c935b7 
and add script to wait until we have the backingdtore pod

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the update-workflow-admission branch from 11bc4e7 to 7c935b7 Compare March 9, 2023 12:46
@shirady shirady requested a review from liranmauda March 9, 2023 13:27
@shirady shirady closed this Mar 16, 2023
@shirady shirady reopened this Mar 16, 2023
@shirady shirady merged commit f735850 into noobaa:master Mar 16, 2023
@shirady shirady deleted the update-workflow-admission branch March 16, 2023 18:11
@shirady shirady mentioned this pull request Jun 27, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees

@shirady shirady

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirady @liranmauda