Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): HMR error #5460

Merged
merged 2 commits into from
Feb 14, 2022
Merged

fix(vue): HMR error #5460

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af1bba
fix HMR error in vue
indus Feb 11, 2022
44cee37
Update get-children.js
indus Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix HMR error in vue 
this fixes `TypeError: originalSlots[slotName] is not a function` error during HMR in vue by ensuring the function exists.
  • Loading branch information
@indus
indus authored Feb 11, 2022
commit 2af1bba0c23d051b8d0ba746fd3098331681d625
1 change: 1 addition & 0 deletions src/vue/get-children.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function getChildren(originalSlots = {}, slidesRef, oldSlidesRef) {
};

Object.keys(originalSlots).forEach((slotName) => {
if (typeof originalSlots[slotName] !== "function") return;
const els = originalSlots[slotName]();
getSlidesFromElements(els, slotName);
});
Expand Down