-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax parseOrigin validation to allow paths withe "/" #4000
Open
ahmed-oues
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
ahmed-oues:fix-parse-origin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add unit tests for parseOrigin function
- Loading branch information
commit f175a7317f68bebc1fee09280d03b5a7bee4bb8f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
'use strict' | ||
|
||
const { test } = require('node:test') | ||
const assert = require('node:assert') | ||
const { parseOrigin } = require('../lib/core/util') | ||
|
||
// Test cases for parseOrigin functionality | ||
test('parseOrigin allows URLs with paths and rejects invalid ones', async (t) => { | ||
// Valid URL with path | ||
const validUrl = 'https://api.domain.com/elastic' | ||
const result = parseOrigin(validUrl) | ||
assert.strictEqual(result.href, validUrl, 'Should return the input URL with the path for valid cases') | ||
|
||
// Invalid URL with query string | ||
const invalidQueryUrl = 'https://api.domain.com/elastic?query=test' | ||
assert.throws( | ||
() => parseOrigin(invalidQueryUrl), | ||
/InvalidArgumentError/, | ||
'Should throw InvalidArgumentError for URLs with query strings' | ||
) | ||
|
||
// Invalid URL with fragment | ||
const invalidFragmentUrl = 'https://api.domain.com/elastic#section' | ||
assert.throws( | ||
() => parseOrigin(invalidFragmentUrl), | ||
/InvalidArgumentError/, | ||
'Should throw InvalidArgumentError for URLs with fragments' | ||
) | ||
|
||
// Valid URL without path | ||
const validSimpleUrl = 'https://api.domain.com' | ||
const simpleResult = parseOrigin(validSimpleUrl) | ||
assert.strictEqual(simpleResult.href, `${validSimpleUrl}/`, 'Should return the input URL with the trailing slash') | ||
}) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it impact
undici.request()
and other methods? Can you add a test for that?