Relax parseOrigin validation to allow paths withe "/" #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Jan 13, 2025
|
Hi @mcollina, I've added unit tests for the parseOrigin function to validate the changes. The tests confirm URLs with paths are now accepted while invalid cases are still rejected. Let me know if further adjustments are needed. 😊 |
mcollina
requested changes
Jan 14, 2025
| const validSimpleUrl = 'https://api.domain.com' | ||
| const simpleResult = parseOrigin(validSimpleUrl) | ||
| assert.strictEqual(simpleResult.href, `${validSimpleUrl}/`, 'Should return the input URL with the trailing slash') | ||
| }) |
There was a problem hiding this comment.
How does it impact undici.request() and other methods? Can you add a test for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#3999
This pull request resolves an issue with overly restrictive URL validation in the
parseOriginfunction incore/util.js. Specifically, the function was rejecting valid URLs with paths.Rationale
The previous implementation of
parseOriginrejected URLs with paths, such ashttps://api.domain.com/elastic, even though such URLs are valid in many use cases. By relaxing the condition on thepathnamecheck, the function now allows URLs with paths, while still maintaining validation for query strings (search) and fragments (hash).This change makes the library more flexible and usable in real-world scenarios where Elasticsearch and other similar services often use paths in their base URLs.
Changes
parseOriginfunction incore/util.jsto relax the validation logic forpathname.Features
N/A – this is not a new feature but a bug fix.
Bug Fixes
parseOriginfunction, allowing URLs with paths.Breaking Changes and Deprecations
The modified validation does not affect existing use cases where paths were not used in URLs. It only adds support for previously invalid cases.
Status