Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase timeouts for test/issue-3346.js #3970

Closed
wants to merge 5 commits into from
Closed

increase timeouts for test/issue-3346.js #3970

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5241094
increase timeouts for test/issue-3346.js
mcollina Dec 23, 2024
d7e5c57
Revert "increase timeouts for test/issue-3346.js"
targos Dec 23, 2024
b9c901a
increase timeouts for test/issue-3346.js
targos Dec 23, 2024
e672552
1500 is not enough
targos Dec 23, 2024
928ba1c
remove timeout
targos Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
increase timeouts for test/issue-3346.js 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Dec 23, 2024
commit 524109400a7a56f27312c58aafffd49479c0fa27
4 changes: 2 additions & 2 deletions test/issue-3356.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ test('https://github.com/nodejs/undici/issues/3356', async (t) => {

res.flushHeaders()
res.write('h')
setTimeout(() => { res.end('ello world!') }, 100)
setTimeout(() => { res.end('ello world!') }, 1100)
} else {
res.end('hello world!')
}
Expand Down Expand Up @@ -54,7 +54,7 @@ test('https://github.com/nodejs/undici/issues/3356', async (t) => {
t.equal(err.name, 'TypeError')
t.equal(err.cause.code, 'UND_ERR_REQ_RETRY')
}
}, 200)
}, 2000)

await t.completed
})
Loading