Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing error type #3964

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

Gigioliva
Copy link
Contributor

@Gigioliva Gigioliva commented Dec 18, 2024

Add missing TS type for ResponseError

Catch the error thrown by responseError interceptor

Changes

Add missing type for ResponseError

Bug Fixes

Let typescript know the type of the error in order to use it in a try/catch

Status

@Gigioliva Gigioliva force-pushed the feat/add-missing-type branch from 9a4487e to 8a64d88 Compare December 18, 2024 22:33
statusCode: number
body: null | Record<string, any> | string
headers: IncomingHttpHeaders | string[] | null
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What API is emitting this error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is in the description. The new responseError interceptor

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8044a43 into nodejs:main Dec 19, 2024
31 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants