Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: do not set undefined etag #3925

Merged
merged 1 commit into from
Dec 5, 2024
Merged

cache: do not set undefined etag #3925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
do not set undefined header 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Dec 4, 2024
commit 4b06e953c2a1f88ab1e10e175342b5f907066f72
7 changes: 5 additions & 2 deletions lib/interceptor/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,11 @@ function handleResult (

let headers = {
...opts.headers,
'if-modified-since': new Date(result.cachedAt).toUTCString(),
'if-none-match': result.etag
'if-modified-since': new Date(result.cachedAt).toUTCString()
}

if (result.etag) {
headers.etag = result.etag
}

if (result.vary) {
Expand Down
Loading