Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove websocket experimental warning #3311

Merged
merged 3 commits into from
Jun 6, 2024
Merged

remove websocket experimental warning #3311

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98473c2
remove websocket experimental warning
KhafraDev Jun 5, 2024
add33ae
??
KhafraDev Jun 5, 2024
2217a54
fixup
KhafraDev Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
??
  • Loading branch information
@KhafraDev
KhafraDev committed Jun 5, 2024
commit add33aebbb0404d3ae17a782ac4182c8f5a457f7
3 changes: 0 additions & 3 deletions test/node-test/debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// eslint-disable-next-line no-control-regex
const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g

test('debug#websocket', { skip: !process.versions.icu }, async t => {

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, macos-latest) / Test with Node.js 22 on macos-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, ubuntu-latest) / Test with Node.js 21 on ubuntu-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, ubuntu-latest) / Test with Node.js 20 on ubuntu-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, ubuntu-latest) / Test with Node.js 22 on ubuntu-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, ubuntu-latest) / Test with Node.js 18 on ubuntu-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, macos-latest) / Test with Node.js 18 on macos-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, macos-latest) / Test with Node.js 21 on macos-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 11 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, macos-latest) / Test with Node.js 20 on macos-latest

debug#websocket 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}
const assert = tspl(t, { plan: 8 })
const child = spawn(
process.execPath,
Expand All @@ -22,9 +22,6 @@
const chunks = []
const assertions = [
/(WEBSOCKET [0-9]+:) (connecting to)/,
// Skip the chunk that comes with the experimental warning
/(\[UNDICI-WS\])/,
/\(Use `node --trace-warnings \.\.\.` to show where the warning was created\)/,
/(WEBSOCKET [0-9]+:) (connected to)/,
/(WEBSOCKET [0-9]+:) (sending request)/,
/(WEBSOCKET [0-9]+:) (connection opened)/,
Expand All @@ -47,7 +44,7 @@
await assert.completed
})

test('debug#fetch', async t => {

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, macos-latest) / Test with Node.js 22 on macos-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, ubuntu-latest) / Test with Node.js 21 on ubuntu-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, ubuntu-latest) / Test with Node.js 20 on ubuntu-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, ubuntu-latest) / Test with Node.js 22 on ubuntu-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, ubuntu-latest) / Test with Node.js 18 on ubuntu-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, macos-latest) / Test with Node.js 18 on macos-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, macos-latest) / Test with Node.js 21 on macos-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 47 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, macos-latest) / Test with Node.js 20 on macos-latest

debug#fetch 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}
const assert = tspl(t, { plan: 7 })
const child = spawn(
process.execPath,
Expand Down Expand Up @@ -81,7 +78,7 @@
await assert.completed
})

test('debug#undici', async t => {

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, macos-latest) / Test with Node.js 22 on macos-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, ubuntu-latest) / Test with Node.js 21 on ubuntu-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, ubuntu-latest) / Test with Node.js 20 on ubuntu-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (22, ubuntu-latest) / Test with Node.js 22 on ubuntu-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:520:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, ubuntu-latest) / Test with Node.js 18 on ubuntu-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (18, macos-latest) / Test with Node.js 18 on macos-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:517:28) {
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved',
  code: 'ERR_TEST_FAILURE'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (21, macos-latest) / Test with Node.js 21 on macos-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}

Check failure on line 81 in test/node-test/debug.js

View workflow job for this annotation

GitHub Actions / test (20, macos-latest) / Test with Node.js 20 on macos-latest

debug#undici 

Error [ERR_TEST_FAILURE]: Promise resolution is still pending but the event loop has already resolved
    at process.emit (node:events:519:28) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'cancelledByParent',
  cause: 'Promise resolution is still pending but the event loop has already resolved'
}
// Due to Node.js webpage redirect
const assert = tspl(t, { plan: 7 })
const child = spawn(
Expand Down
Loading