Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port client-connect, client-dispatch, client-errors test to node:test #2591

Merged
merged 11 commits into from
Jan 16, 2024
Merged

feat: port client-connect, client-dispatch, client-errors test to node:test #2591

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00c7cd2
`client-connect`
sosukesuzuki Jan 3, 2024
4f4bfb1
`client-dispatch`
sosukesuzuki Jan 3, 2024
74d6d7e
`client-errors`
sosukesuzuki Jan 4, 2024
c643b85
Use `done` instead of `t.end`
sosukesuzuki Jan 4, 2024
5e1d701
Fix `t.after`
sosukesuzuki Jan 5, 2024
7aaff7a
Update `return client.close()`
sosukesuzuki Jan 6, 2024
b36ead7
Update `client-errors` without `parser error` tests
sosukesuzuki Jan 11, 2024
159c39c
Add FIXME comment
sosukesuzuki Jan 11, 2024
eca036c
Use `closeServerAsPromise` for `client-dispatch`
sosukesuzuki Jan 11, 2024
62dd4ff
Use `closeServerAsPromise` for `client-connect`
sosukesuzuki Jan 11, 2024
bc36686
Leave some tests on tap
sosukesuzuki Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use closeServerAsPromise for client-connect
  • Loading branch information
@sosukesuzuki
sosukesuzuki committed Jan 11, 2024
commit 62dd4fff9e79dbab00d02ac6782e54183419ffbb
14 changes: 8 additions & 6 deletions test/node-test/client-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const http = require('http')
const EE = require('events')
const { kBusy } = require('../../lib/core/symbols')
const { tspl } = require('@matteo.collina/tspl')
const { closeServerAsPromise } = require('../utils/node-http')

test('basic connect', async (t) => {
const p = tspl(t, { plan: 3 })
Expand All @@ -25,7 +26,7 @@ test('basic connect', async (t) => {
socket.end(data)
})
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
Expand Down Expand Up @@ -65,7 +66,7 @@ test('connect error', async (t) => {
server.on('connect', (req, socket, firstBodyChunk) => {
socket.destroy()
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
Expand Down Expand Up @@ -131,7 +132,7 @@ test('connect wait for empty pipeline', async (t) => {
socket.end(data)
})
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`, {
Expand Down Expand Up @@ -188,7 +189,7 @@ test('connect aborted', async (t) => {
server.on('connect', (req, c, firstBodyChunk) => {
p.ok(0)
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, () => {
const client = new Client(`http://localhost:${server.address().port}`, {
Expand Down Expand Up @@ -238,7 +239,7 @@ test('basic connect error', async (t) => {
socket.end(data)
})
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
Expand Down Expand Up @@ -268,7 +269,7 @@ test('connect invalid signal', async (t) => {
server.on('connect', (req, c, firstBodyChunk) => {
p.ok(0)
})
t.after(server.close.bind(server))
t.after(closeServerAsPromise(server))

server.listen(0, () => {
const client = new Client(`http://localhost:${server.address().port}`)
Expand Down Expand Up @@ -301,6 +302,7 @@ test('connect aborted after connect', async (t) => {
server.on('connect', (req, c, firstBodyChunk) => {
signal.emit('abort')
})
// FIXME: use closeServerAsPromise
t.after(server.close.bind(server))

server.listen(0, () => {
Expand Down