Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(fetch): Improve fetch of detaurl #2479

Merged
merged 20 commits into from
Dec 8, 2023
Merged

perf(fetch): Improve fetch of detaurl #2479

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0186b89
perf(fetch): Improve data url base64
tsctx Nov 30, 2023
ed8f08e
format
tsctx Nov 30, 2023
85959c9
fix: comment position
tsctx Nov 30, 2023
e6cc715
add comment
tsctx Nov 30, 2023
de7eeee
add comment
tsctx Nov 30, 2023
99a9f09
suggestion change
tsctx Nov 30, 2023
cd93cdb
perf: avoid replace
tsctx Dec 1, 2023
058dc02
fixup
tsctx Dec 1, 2023
6e4588c
refactor
tsctx Dec 1, 2023
05a4721
fixup
tsctx Dec 1, 2023
a7ff05a
Revert "fixup"
tsctx Dec 1, 2023
269c7c4
fixup
tsctx Dec 1, 2023
00d30a8
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 1, 2023
500a930
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 1, 2023
be46141
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 2, 2023
3357f5e
Merge branch 'main' of github.com:tsctx/undici into perf/improve-data…
tsctx Dec 2, 2023
93bf00d
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 3, 2023
7a95eb8
remove
tsctx Dec 3, 2023
b95a922
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 4, 2023
b5514d7
Merge remote-tracking branch 'origin' into perf/improve-data-url-base64
tsctx Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fixup" 
This reverts commit 058dc02.
  • Loading branch information
@tsctx
tsctx committed Dec 1, 2023
commit a7ff05a4e128589c4c114c62ac2362dc9fad1338
5 changes: 1 addition & 4 deletions lib/fetch/dataURL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,8 @@ function forgivingBase64 (data) {
if (dataLength % 4 === 0) {
// 1. If data ends with one or two U+003D (=) code points,
// then remove them from data.
if (data.charCodeAt(dataLength - 1) === 0x003D) {
if (data.charCodeAt(dataLength - 1) === 0x003D && data.charCodeAt(--dataLength) === 0x003D) {
--dataLength
if (data.charCodeAt(dataLength - 1) === 0x003D) {
--dataLength
}
}
}

Expand Down
Loading