fix: only throw error responses (#1076)

Fixes: #1072
nodejs · Oct 27, 2021 · 48d9578 · 48d9578
1 parent 7b03c91
commit 48d9578
Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/fetch/index.js b/lib/fetch/index.js
@@ -171,7 +171,7 @@ async function fetch (...args) {
 
     // 3. If response is a network error, then reject p with a TypeError
     // and terminate these substeps.
-    if (response.status === 0) {
+    if (response.type === 'error') {
       p.reject(
         Object.assign(new TypeError('fetch failed'), { cause: response.error })
       )

diff --git a/test/node-fetch/main.js b/test/node-fetch/main.js
@@ -409,14 +409,14 @@ describe('node-fetch', () => {
     })
   })
 
-  xit('should treat broken redirect as ordinary response (manual)', () => {
+  it('should treat broken redirect as ordinary response (manual)', () => {
     const url = `${base}redirect/no-location`
     const options = {
       redirect: 'manual'
     }
     return fetch(url, options).then(res => {
       expect(res.url).to.equal(url)
-      expect(res.status).to.equal(301)
+      expect(res.status).to.equal(0)
       expect(res.headers.get('location')).to.be.null
     })
   })