Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: better log message when ps fails #2229

Closed
wants to merge 5 commits into from
Closed

lib: better log message when ps fails #2229

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e98bb16
doc: drop the --production flag for installing windows-build-tools
DeeDeeG Aug 29, 2020
d1176d7
ci: switch to GitHub Actions
codebytere May 13, 2020
9bf112b
doc: replace status badges with new Actions badge
rvagg Sep 9, 2020
8ee5d3e
lib: better log message when ps fails
initram Sep 29, 2020
9b9b948
lib: made the log message for ps errors less definate
initram Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: better log message when ps fails
  • Loading branch information
@initram
initram committed Sep 29, 2020
commit 8ee5d3eddb93c598cd09784918c0a95a187404c7
2 changes: 1 addition & 1 deletion lib/find-visualstudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ VisualStudioFinder.prototype = {

const failPowershell = () => {
this.addLog(
'could not use PowerShell to find Visual Studio 2017 or newer')
'could not use PowerShell to find Visual Studio 2017 or newer, run command with \'--loglevel silly\' to figure out why')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit too definite, you may not figure out why. Maybe:

"try re-running with --loglevel=silly for more details"

cb(null)
}

Expand Down