Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix argv memory leaking in FixupArgsForSEA #55579

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

src: fix argv memory leaking in FixupArgsForSEA #55579

wants to merge 3 commits into from

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Oct 29, 2024 •
edited
Loading

It was allocated here

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (45c6a9e) to head (d3552b9).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/node.cc 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55579      +/-   ##
==========================================
+ Coverage   88.36%   88.43%   +0.07%     
==========================================
  Files         652      654       +2     
  Lines      187245   187731     +486     
  Branches    35990    36137     +147     
==========================================
+ Hits       165451   166018     +567     
+ Misses      15074    14953     -121     
- Partials     6720     6760      +40
Files with missing lines Coverage Δ
src/node.cc 73.82% <80.00%> (-0.42%) ⬇️

... and 59 files with indirect coverage changes

@CGQAQ CGQAQ force-pushed the fix-memory-leak-1 branch from 178ae6b to 21951c6 Compare October 29, 2024 07:29
@avivkeller avivkeller added windows Issues and PRs related to the Windows platform. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 29, 2024
joyeecheung
joyeecheung reviewed Oct 30, 2024
View reviewed changes
src/node_sea.cc Outdated Show resolved Hide resolved
@CGQAQ CGQAQ requested a review from joyeecheung November 1, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CGQAQ @nodejs-github-bot @jasnell @joyeecheung @avivkeller