child_process.flushStdio: resume _consuming streams

When a client calls read() with a nonzero argument on a Socket, that Socket sets this._consuming to true. It never sets this._consuming back to false. child_process.flushStdio currently doesn't flush any streams where _consuming is truthy. But that means that it never flushes any stream that has ever been read from. This prevents a child process from ever closing if one of its streams has been read from, causing issue #4049. child_process.flushStdio should flush streams even if their _consuming is set to true. Then it will close even after a read.
nodejs · davidvgalbraith · Nov 30, 2015 · Nov 30, 2015 · Nov 30, 2015 · Nov 30, 2015
commit f2c8cb5a7fb321c3d814ddeefe6e10517360f73c
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -217,7 +217,7 @@ util.inherits(ChildProcess, EventEmitter);
 function flushStdio(subprocess) {
   if (subprocess.stdio == null) return;
   subprocess.stdio.forEach(function(stream, fd, stdio) {
-    if (!stream || !stream.readable || stream._consuming)
+    if (!stream || !stream.readable)
       return;
     stream.resume();
   });

diff --git a/test/sequential/test-child-process-flush-stdio.js b/test/sequential/test-child-process-flush-stdio.js
@@ -0,0 +1,13 @@
+'use strict';
+const cp = require('child_process');
+const common = require('../common');
+
+var p = cp.spawn('yes');
+
+p.on('close', common.mustCall(function() {}));
+
+p.stdout.read();
+
+setTimeout(function() {
+  p.kill();
+}, 100);