Don't reuse _optimization_iterator - fixes crash on multiple note del…

…ete undo.
nmains · Jan 13, 2015 · 5ef868e · 5ef868e
1 parent 7a3662b
commit 5ef868e
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/gtk2_ardour/midi_region_view.cc b/gtk2_ardour/midi_region_view.cc
@@ -1117,17 +1117,11 @@ MidiRegionView::find_canvas_note (boost::shared_ptr<NoteType> note)
 NoteBase*
 MidiRegionView::find_canvas_note (NoteType note)
 {
-	if (_optimization_iterator != _events.end()) {
-		++_optimization_iterator;
-	}
-
-	if (_optimization_iterator != _events.end() && (*(*_optimization_iterator)->note()) == note) {
-		return *_optimization_iterator;
-	}
+	Events::iterator it;
 
-	for (_optimization_iterator = _events.begin(); _optimization_iterator != _events.end(); ++_optimization_iterator) {
-		if (*((*_optimization_iterator)->note()) == note) {
-			return *_optimization_iterator;
+	for (it = _events.begin(); it != _events.end(); ++it) {
+		if (*((*it)->note()) == note) {
+			return *it;
 		}
 	}