Merge pull request kubernetes#18331 from janetkuo/fix-deployment-getn…

…ewrc Fix bug when getting new RC of a deployment
nikhiljindal · Dec 10, 2015 · 9d1f07d · 9d1f07d
2 parents b9aa710 + 72bd4e8
commit 9d1f07d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/util/deployment/deployment.go b/pkg/util/deployment/deployment.go
@@ -77,10 +77,10 @@ func GetNewRC(deployment extensions.Deployment, c client.Interface) (*api.Replic
 	}
 	newRCTemplate := GetNewRCTemplate(deployment)
 
-	for _, rc := range rcList.Items {
-		if api.Semantic.DeepEqual(rc.Spec.Template, &newRCTemplate) {
+	for i := range rcList.Items {
+		if api.Semantic.DeepEqual(rcList.Items[i].Spec.Template, &newRCTemplate) {
 			// This is the new RC.
-			return &rc, nil
+			return &rcList.Items[i], nil
 		}
 	}
 	// new RC does not exist.