Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ES6 modules JavaScript with webpack #258

Merged
merged 26 commits into from
Dec 17, 2018
Merged

Implement ES6 modules JavaScript with webpack #258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d478815
[refs #96] Implement ES6 modules JavaScript with webpack
chrimesdev Nov 27, 2018
4590f4a
[refs #96] Use eslint with the shared NHS.UK config
chrimesdev Nov 27, 2018
506b517
[refs #96] Use gulp to build our Javascript with webpack
chrimesdev Nov 28, 2018
4cf4ab6
[refs #107] Fix a typo in the feedback banner example
chrimesdev Nov 28, 2018
10cc83a
[refs #96] Refactor feedback banner JS to an ES6 module
chrimesdev Nov 28, 2018
67743a1
[refs #96] Refactor skip link JS to an ES6 module
chrimesdev Nov 28, 2018
5781149
[refs #96] Refactor header JS to an ES6 module
chrimesdev Nov 28, 2018
30dfb9b
[refs #96] Tidy up gulp tasks for bundling JavaScript
chrimesdev Nov 29, 2018
e55af5a
[refs #96] Move eslint config file and run linters on test
chrimesdev Nov 29, 2018
1b381a3
[refs #107] Use htmlhint to lint HTML and fix issues
chrimesdev Nov 29, 2018
905e739
Merge branch 'master' into feature/es6-webpack
chrimesdev Dec 3, 2018
848544b
Merge branch 'master' into feature/es6-webpack
chrimesdev Dec 5, 2018
8343aa8
[refs #96] Refactor unsticky feedback banner JS to ES6
chrimesdev Dec 5, 2018
e7eaf83
[refs #96] Use babel preset in webpack for IE10> polyfill
chrimesdev Dec 5, 2018
e6a6e86
[refs #96] Check banner element exists before eventListener
chrimesdev Dec 5, 2018
f02cb5c
[refs #96] Include the missing details.js file
chrimesdev Dec 5, 2018
d8a2d6e
Merge branch 'master' into feature/es6-webpack
chrimesdev Dec 12, 2018
2e6f9e9
[refs #96] Prefix JavaScript modules with nhsuk_
chrimesdev Dec 12, 2018
288f4a7
[refs #96] Include details polyfill via modules
chrimesdev Dec 12, 2018
1fb4459
[refs #96] Minify JavaScript ES6 bundle for npm installations
chrimesdev Dec 17, 2018
5858b13
Merge branch 'master' into feature/es6-webpack
chrimesdev Dec 17, 2018
c0dfc96
[refs #96] Compile the JavaScript to dist instead of packages
chrimesdev Dec 17, 2018
cf0e7a5
[refs #96] ES6 JavaScript install docs and delete specific tools exam…
chrimesdev Dec 17, 2018
af95188
[refs #96] ignore the versioned assets for npm packages
chrimesdev Dec 17, 2018
1d079e8
[refs #96] Fix skip-link js and use DOMContentLoaded
mcheung-nhs Dec 17, 2018
3ecd825
[refs #96] Fix JS eslint issues for arrow functions
chrimesdev Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[refs #96] Implement ES6 modules JavaScript with webpack 
Use modules to expose components individual logic and compile
them into a single JavaScript file using webpack and ES6. Refactor
emergency banner JavaScript as an example. Still a work in progress,
need to refactor the configuration and further components.
  • Loading branch information
@chrimesdev
chrimesdev committed Nov 29, 2018
commit d47881531db19509e6b4f4ef5d996aa597bea4a4
1 change: 1 addition & 0 deletions build/nhsuk.bundle.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/_templates/layout.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<link rel="stylesheet" href="{{ baseUrl }}/assets/nhsuk.css">

<script src="{{ baseUrl }}/assets/nhsuk.js" defer></script>
<script src="{{ baseUrl }}/assets/nhsuk.bundle.js" defer></script>
<script src="{{ baseUrl }}/assets/libraries/jquery.min.js"></script>

<!--[if IE]><link rel="shortcut icon" href="{{ baseUrl }}/assets/favicons/favicon.ico"><![endif]-->
Expand Down
1 change: 0 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ function compileJS() {
'packages/components/header/typeahead.bundle.min.js',
'packages/components/header/nhs.typeahead.js',
'packages/components/header/header.js',
'packages/components/feedback-banner/feedback-banner.js',
'packages/components/skip-link/skip-link.js'
])
.pipe(concat('nhsuk.js'))
Expand Down
Loading