Skip to content

Commit

Permalink
prefs: always prompt for download directory by default
Browse files Browse the repository at this point in the history
If the user opens a link, one of two things might happen. The URI
resolves to a "web page" and will be displayed, then everything is
good. Or it has a MIME type like application/* or so that causes the
browser to consider it a file download instead.

In that case, one of two things might happen. The browser may display
a dialog box asking explicitly for an action, then everything is
good. Or it does not and instead readily stores the file on disk.

(Modern browsers also download the file in the background when waiting
for the dialog box confirmation, but that is a separate tuning knob.)

When the file is chosen to be immediately stored on disk without user
interaction, the visual feedback for this may be rather miniscule.

And then, you have to open a terminal or file manager again just to
move the file to the location you wanted it to be in in the first
place.

TLDR: Do not let files sneak onto the disk too easily.
  • Loading branch information
jengelh committed Nov 14, 2023
1 parent d4b4f36 commit 9f83179
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/browser/download/download_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ void DownloadPrefs::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(
prefs::kPromptForDownload,
false,
true,
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
registry->RegisterStringPref(prefs::kDownloadExtensionsToOpen, std::string());
registry->RegisterListPref(prefs::kDownloadExtensionsToOpenByPolicy, {});
Expand Down

0 comments on commit 9f83179

Please sign in to comment.