Feature: Add Collabora as a subchart #611 #623
Conversation
Signed-off-by: kriegalex <kriegalex@gmail.com>
Signed-off-by: kriegalex <kriegalex@gmail.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
|
Oh, awesome! Thanks, @kriegalex for this PR! Right now the workflow is failing: You can fix this by adding the helm repo for collabora to this section of the workflow file, similar to how we do for bitnami: helm/.github/workflows/lint-test.yaml Lines 39 to 41 in b25b4ad |
There was a problem hiding this comment.
looks great, but we need to ensure the tests still work, so I left a comment about how to update the GHA workflow. If you can, it would also be neat to have a test for collabora itself as well, but we can also hold off on that for a separate PR if you'd like. 🙏
update: added the commit to maybe fix the tests :)
…testing Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
|
Thanks for the change on lint tests. I'm still learning k8s, didn't think of that. |
Signed-off-by: kriegalex <kriegalex@gmail.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Description of the change
Benefits
Possible drawbacks
extra_params,server_name,aliasgroupsandannotations.Applicable issues
Additional information
Tested on my local kubernetes cluster with a HTTPS nginx ingress. Nextcloud can communicate with Collabora. Not tested with HAProxy (though it is only a change in annotations specific to HAProxy).
Checklist
Chart.yamlaccording to semver.