Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: alienngator/cld2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: newtonapple/cld2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 52 files changed
  • 2 contributors

Commits on Dec 10, 2017

  1. Configuration menu
    Copy the full SHA
    c3f9e6f View commit details
    Browse the repository at this point in the history
  2. Update CLD2 to master.

    newtonapple committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    7c964ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a2bba1 View commit details
    Browse the repository at this point in the history
  4. Revert CLD.detect_language back to its old API (remove verbose) and a…

    …dd a new CLD.detect_language_summary.
    
    Also updated FFI to 1.9.18 & RSpec to 3.7.0.
    newtonapple committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    46dda88 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Introduce new APIs:

      - CLD.detect_language (returns a Hash)
      - CLD.detect (returns a ResultValue)
      - CLD.detect_language_with_summary (returns a Hash)
      - CLD.detect_with_summary (returns a ResultValue)
      - CLD.Encoding (an enum)
      - CLD.Language (an enum)
      - CLD.language_from_name (takes "English" or "en" and returns CLD.Language[:ENGLISH])
    newtonapple committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    6f68f55 View commit details
    Browse the repository at this point in the history
  2. Patch memory leak in detect_with_summary.

    Add language_id (int) to all the structs. We'll be removing code and name
    from all structs in the future. Instead, they can be generated on the fly.
    David Dai committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    683017a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. Reworked API to not expose internal SummaryResult (pointer). SummaryR…

    …esult memory copying and
    
    freeing is done automatically via factory API: CLD.detect_summary.
    
    Also reworked FFI structs to not pass code & names.  Instead, we'll now use the exposed C APIs to
    translate internal Language type (ENUM) to proper the code & name.
    
    Primary public APIs:
      - CLD.detect_language (returns a Hash)
      - CLD.detect (returns a private Result)
      - CLD.detect_language_summary (returns a Hash)
      - CLD.detect_summary (returns a private Summary)
    David Dai committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    eee1284 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Added specs for CLD.detect_language_summary & updated README.md to re…

    …flect the new APIs.
    David Dai committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    561cc07 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2017

  1. Add specs for CLD2.detect_language_summary :chunks.

    David Dai committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    39e0270 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2017

  1. Configuration menu
    Copy the full SHA
    6e4759a View commit details
    Browse the repository at this point in the history
  2. Adding memory usage profile script.

    David Dai committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    9772fe2 View commit details
    Browse the repository at this point in the history
Loading