(fix) made boolean omitempty values references #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amaor-newrelic
force-pushed
the
fix-channel-active-marshalling-issues
branch
from
ade6c5f
to
ef7e27c
Compare
|
@amaor-newrelic Thank you for your contribution! Sorry for the delay on this. We're doing some feature work that we're hoping to get into v2 before releasing another major version since it's a bit of a hassle in Go. Happy to review once that work is finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE
This PR addresses a number of issues with the API used to update channels and destinations
Unfortunately, it was impossible to implement these changes in a backward-compatible way. The current API is just does not match our GraphQL API.
See this pr for reference