NVSHAS-8532 - Failed to find container's symbolic link at the same folder #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,6 +207,17 @@ func GetContainerRealFilePath(pid int, symlinkPath string, inTest bool) (string, | |||
|
|
|||
| visitedSymlink[currentPath] = struct{}{} | |||
| if underProcRoot { | |||
| if _, err := os.Lstat(resolvedPath); err != nil { | |||
There was a problem hiding this comment.
Check the error first with https://pkg.go.dev/os#IsNotExist ?
share/osutil/file_linux.go
Outdated
| @@ -81,6 +81,74 @@ func extractProcRootPath(pid int, input string, inTest bool) (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| // The retryResolveSymlink splits the path into parts and checks each segment for symlinks, updating the path as it resolves them. | |||
| func retryResolveSymlink(procRoot, prefix, remaining string) (bool, string) { | |||
There was a problem hiding this comment.
Can this logic support this case?
- Resolving
/a/b/cin a container. /ais a symlink pointing to/d/e/f/d/eis another symlink pointing to/g/h/i
The expected result should be /g/h/i/f/b/c. The flow is:
/a/b/c=>/d/e/f+/b/c/d/e/f/b/c=>/g/h/i+/f/b/c=>/g/h/i/f/b/c
But from your code, it might become /d/e/f/b/c?
/a=>/d/e/f/d/e/f+/b=>/d/e/f/b/d/e/f/b+/c=>/d/e/f/b/c
# ls -al a
lrwxrwxrwx 1 root root 6 Jan 25 16:22 a -> /d/e/f
# ls -al /d/e
lrwxrwxrwx 1 root root 6 Jan 25 16:22 /d/e -> /g/h/i
# stat /a/b/c
Device: 20002eh/2097198d Inode: 58720946 Links: 1
# stat /g/h/i/f/b/c
Device: 20002eh/2097198d Inode: 58720946 Links: 1
There was a problem hiding this comment.
Hi @holyspectral ,
Thanks for the review!
You're correct, the correct way is to recursive back to re-run it from beginning.
In new commit, I add a traverse count to limit the number of traverse, and guarantee retry from the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to verify
pohanhuangtw/allinone:8532