fix(core): dependencies not resolving for transient lazy providers #13804
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build ed614f3a-8fae-4c99-8c8e-2e6bfea98225Details
💛 - Coveralls |
|
|
||
| sayHello() { | ||
| this.counter++; | ||
| return 'Hi! Counter is ' + this.counter; |
There was a problem hiding this comment.
question: Is this function here only for debugging purposes or is it actively used? If it is used why not provide a more meaningful message?
Thanks!
| const { TransientLazyModule } = await import('./transient.module'); | ||
| const moduleRef = await this.lazyLoadModule.load(() => TransientLazyModule); | ||
|
|
||
| const { TransientService } = await import('./transient.service'); |
There was a problem hiding this comment.
question: Would it make sense to use Promise.all() or Promise.allSettled() for awaiting these imports in parallel for a slight perf boost?
Thanks!
benjGam
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: Closes #13761
When a lazy module resolver a lazy provider marked as transient the singleton dependencies are recreated for the new requests in same context.
What is the new behavior?
Skipping creation of new providers if they are marked as transient and have annotation in the score of module.
Does this PR introduce a breaking change?
Other information