Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local-proxy suffix to wake-compute requests, respect the returned port #9298

Merged
merged 2 commits into from
Oct 9, 2024
Merged

add local-proxy suffix to wake-compute requests, respect the returned port #9298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a417ebb
add local-proxy suffix to wake-compute requests, respect the returned…
conradludgate Oct 7, 2024
95a23de
error if no port
conradludgate Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
error if no port
  • Loading branch information
@conradludgate
conradludgate committed Oct 9, 2024
commit 95a23de7542fe1f32ce9250ec0af5042e1813e1c
11 changes: 5 additions & 6 deletions proxy/src/serverless/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,12 +429,11 @@ impl ConnectMechanism for HyperMechanism {

let pause = ctx.latency_timer_pause(crate::metrics::Waiting::Compute);

let port = node_info
.config
.get_ports()
.first()
.copied()
.unwrap_or_else(10432);
let port = *node_info.config.get_ports().first().ok_or_else(|| {
HttpConnError::WakeCompute(WakeComputeError::BadComputeAddress(
"local-proxy port missing on compute address".into(),
))
})?;
let res = connect_http2(&host, port, timeout).await;
drop(pause);
let (client, connection) = permit.release_result(res)?;
Expand Down
Loading