fix: Expression passed to evaluateCondition asserted to be valid (A…

…ssemblyScript#2013)
nearprotocol · Aug 2, 2021 · 81c2bad · 81c2bad
1 parent dd5111b
commit 81c2bad
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/src/compiler.ts b/src/compiler.ts
@@ -10067,7 +10067,11 @@ export class Compiler extends DiagnosticEmitter {
 
   /** Evaluates a boolean condition, determining whether it is TRUE, FALSE or UNKNOWN. */
   evaluateCondition(expr: ExpressionRef): ConditionKind {
-    assert(getExpressionType(expr) == TypeRef.I32);
+    let type = getExpressionType(expr);
+    if (type == TypeRef.Unreachable)
+      return ConditionKind.UNKNOWN;
+
+    assert(type == TypeRef.I32);
     var module = this.module;
     var evaled = module.runExpression(expr, ExpressionRunnerFlags.Default);
     if (evaled) {

diff --git a/tests/compiler/unknown-bool-ident.json b/tests/compiler/unknown-bool-ident.json
@@ -0,0 +1,8 @@
+{
+  "asc_flags": [
+  ],
+  "stderr": [
+    "TS2304: Cannot find name 'unknown_var'.",
+    "EOF"
+  ]
+}
diff --git a/tests/compiler/unknown-bool-ident.ts b/tests/compiler/unknown-bool-ident.ts
@@ -0,0 +1,2 @@
+if (1 <= unknown_var) {}
+ERROR("EOF");
diff --git a/tests/compiler/unknown-bool-ident.untouched.wat b/tests/compiler/unknown-bool-ident.untouched.wat