fix: check function's instance class is a subclass of virtual method (A…

…ssemblyScript#1985)
nearprotocol · Jul 23, 2021 · 1958554 · 1958554
1 parent 886a4a6
commit 1958554
Show file tree

Hide file tree

Showing 5 changed files with 5,180 additions and 0 deletions.
diff --git a/src/compiler.ts b/src/compiler.ts
@@ -6947,6 +6947,8 @@ export class Compiler extends DiagnosticEmitter {
     // Wouldn't be here if there wasn't at least one overload
     var overloadPrototypes = assert(instance.prototype.overloads);
 
+    assert(instance.parent.kind == ElementKind.CLASS || instance.parent.kind == ElementKind.INTERFACE);
+    var parentClassInstance = <Class>instance.parent;
     var module = this.module;
     var usizeType = this.options.usizeType;
     var sizeTypeRef = usizeType.toRef();
@@ -6992,6 +6994,8 @@ export class Compiler extends DiagnosticEmitter {
       if (classInstances) {
         for (let _values = Map_values(classInstances), j = 0, l = _values.length; j < l; ++j) {
           let classInstance = _values[j];
+          // Chcek if the parent class is a subtype of instance's class
+          if (!classInstance.isAssignableTo(parentClassInstance)) continue;
           let overloadInstance: Function | null;
           if (isProperty) {
             let boundProperty = assert(classInstance.members!.get(unboundOverloadParent.name));

diff --git a/tests/compiler/class-overloading-cast.json b/tests/compiler/class-overloading-cast.json
@@ -0,0 +1,5 @@
+{
+  "asc_flags": [
+    "--explicitStart"
+  ]
+}