Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate support for FailOverRpcProvider into wallet-selector #1125

Closed
charleslavon opened this issue Jun 27, 2024 · 2 comments
Closed

Integrate support for FailOverRpcProvider into wallet-selector #1125

charleslavon opened this issue Jun 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@charleslavon
Copy link

Is your feature request related to a problem? Please describe.
Wallet-selector is currently hardcoded to use a single RPCProvider per network - https://rpc.mainnet.near.org and https://rpc.testnet.near.org

Describe the solution you'd like
Update wallet-selector's initialization method to leverage FailOverRpcProvider in setupWalletSelector and allow developers to specify multiple RPC Provider URLs such that wallet-selector instances can benefit from automatic failover to additional providers given service disruption in the first provider.

Acceptance criteria

  • Unit tests should be added which verify the failover behavior
  • Examples should be added to demonstrate how one should initialize wallet-selector in order to enable multiple RpcProvider

Additional context
FailOverRpcProvider was added into near-api-js here
@charleslavon charleslavon added the enhancement New feature or request label Jun 27, 2024
@github-project-automation github-project-automation bot moved this to NEW❗ in DevRel Jun 27, 2024
@charleslavon
Copy link
Author

hey @hcho112 @andy-haynes kindly review this request and provide any feedback

This was referenced Jul 23, 2024
Closed
Merged
@pivanov
Copy link
Contributor

pivanov commented Aug 21, 2024

done in #1153

@pivanov pivanov closed this as completed Aug 21, 2024
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevRel Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
DevRel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pivanov @charleslavon