Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions for all relevant JS commands #345

Merged
merged 42 commits into from
Jul 9, 2024
Merged

Add suggestions for all relevant JS commands #345

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
228a8a3
initial fixing suggested commands for js versions + test
garikbesson May 23, 2024
6acbce5
building suggestion for js version of commands
garikbesson Jun 4, 2024
6fc63a8
account creation tests + fixes
garikbesson Jun 10, 2024
447807f
tests for deleting account
garikbesson Jun 10, 2024
a761226
updated test framework
gagdiez Jun 11, 2024
c61b700
fix regex in tests
garikbesson Jun 12, 2024
f8b59b4
tests for checking storage/state functions
garikbesson Jun 12, 2024
63dbdbb
contract, key actions testcases, fixed delete_key and deploy functions
garikbesson Jun 13, 2024
fe10614
credentials, keys and near actions tests
garikbesson Jun 17, 2024
8153485
removed debug logs
garikbesson Jun 17, 2024
437037b
Update src/js_command_match/add_credentials.rs
gagdiez Jun 19, 2024
42d3305
Update src/js_command_match/add_credentials.rs
gagdiez Jun 19, 2024
7579ca2
experimental JS commands translation
frol Jun 19, 2024
c0d8ce5
refactored the unit-test to use clap::Parser
frol Jun 25, 2024
1fdac41
using keychain for creating account (js syntax)
garikbesson Jun 27, 2024
388a7d3
CreateAccountArgs::to_cli_args unit tests
garikbesson Jun 28, 2024
50b13c3
removed integration js tests, added add_credentials unit tests, moved…
garikbesson Jun 28, 2024
38345ea
AddKeyArgs::to_cli_args unit tests
garikbesson Jun 29, 2024
b68e151
CallArgs::to_cli_args unit tests
garikbesson Jun 29, 2024
0b74e6a
DeleteAccountArgs::to_cli_args unit tests
garikbesson Jun 29, 2024
bceba36
[...]Args::to_cli_args unit tests
garikbesson Jul 2, 2024
63f10a4
chore: format files
gagdiez Jul 4, 2024
ee2deb2
chore: re-organize and evaluate
gagdiez Jul 4, 2024
b1b6835
fix: various commands
gagdiez Jul 5, 2024
c31b332
fix: merge conflict
gagdiez Jul 5, 2024
78f031c
chore: format
gagdiez Jul 5, 2024
d767b84
chore: remove unnecesary pub
gagdiez Jul 5, 2024
3f7034d
fix: add back existing pub
gagdiez Jul 5, 2024
e544418
feat: clippy
gagdiez Jul 5, 2024
8900733
Apply suggestions from code review
gagdiez Jul 5, 2024
26521a3
apply code suggestions
gagdiez Jul 5, 2024
be125ee
minor refactoring
frol Jul 5, 2024
e594f6f
suggestion for refactoring (two options)
frol Jul 5, 2024
9e0fb9a
apply minor fixes after review
garikbesson Jul 8, 2024
24cff01
refactored suggestions unit tests
garikbesson Jul 9, 2024
46da562
wip
gagdiez Jul 9, 2024
cabe809
Merge branch 'main' into fix-js-commands
gagdiez Jul 9, 2024
0ee1f8e
feat: add path to use-ledger
gagdiez Jul 9, 2024
b02c2d0
fix: aliases and style
gagdiez Jul 9, 2024
0d4b4dd
more code style fixes
garikbesson Jul 9, 2024
ef37494
fixes aliases indexes in unit tests
garikbesson Jul 9, 2024
45e983b
tested JS commands aliases (added missing 'keys', 'import-account', a…
frol Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/js_command_match/add_credentials.rs 
Co-authored-by: Vlad Frolov <frolvlad@gmail.com>
  • Loading branch information
@gagdiez @frol
gagdiez and frol authored Jun 19, 2024
commit 42d33056bfffde7f2f8f9d1fca6dcf85afa91516
2 changes: 1 addition & 1 deletion src/js_command_match/add_credentials.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ mod tests {
seed_phrase: Some(seed_phrase.clone()),
secret_key: None,
network_id: None,
_unknown_args: [].to_vec(),
_unknown_args: vec![],
};
let result = AddCredentialsArgs::to_cli_args(&add_credentials_args, "testnet".to_string());
assert_eq!(
Expand Down