Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sarif] avoid encoding hlint version in tests #1492

Closed
shayne-fletcher opened this issue Apr 3, 2023 · 1 comment · Fixed by #1514
Closed

[sarif] avoid encoding hlint version in tests #1492

shayne-fletcher opened this issue Apr 3, 2023 · 1 comment · Fixed by #1514
Labels
good first issue

Comments

@shayne-fletcher
Copy link
Collaborator

PR #1482 introduces sarif.test. The test output encodes the current hlint version. It would be nice if that can be avoided since these tests will need updating every time the version changes.
@batkot
Copy link
Contributor

batkot commented Jun 10, 2023

Will try to figure it out

@batkot batkot mentioned this issue Jun 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sarif] Remove encoding hlint version in tests batkot/hlint
3 participants
@shayne-fletcher @batkot @zliu41