#669, don't suggest replacing reverse . sort (it's quite fast)

ndmitchell · Apr 1, 2020 · 3933429 · 3933429
1 parent 497b672
commit 3933429
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,5 +1,6 @@
 Changelog for HLint (* = breaking change)
 
+    #669, don't suggest replacing reverse . sort (it's quite fast)
     #939, reduce the span of "Redundant where" to only cover the "where"
     Remove support for GHC 8.4
     Remove support for _eval,

diff --git a/data/hlint.yaml b/data/hlint.yaml
@@ -102,7 +102,8 @@
     - warn: {lhs: sortBy (flip (comparing f)), rhs: sortOn (Down . f)}
     - warn: {lhs: sortBy (comparing f), rhs: sortOn f, side: notEq f fst && notEq f snd}
     - warn: {lhs: reverse (sortOn f x), rhs: sortOn (Data.Ord.Down . f) x, name: Avoid reverse, note: Stabilizes sort order}
-    - warn: {lhs: reverse (sort x), rhs: sortOn Data.Ord.Down x, name: Avoid reverse, note: Stabilizes sort order}
+    # This suggestion likely costs performance, see https://github.com/ndmitchell/hlint/issues/669#issuecomment-607154496
+    # - warn: {lhs: reverse (sort x), rhs: sortOn Data.Ord.Down x, name: Avoid reverse, note: Stabilizes sort order}
     - hint: {lhs: flip (g `on` h), rhs: flip g `on` h, name: Move flip}
     - hint: {lhs: (f `on` g) `on` h, rhs: f `on` (g . h), name: Fuse on/on}