Fix for undefined / ambiguous steps, now we are using the exact selec…

…tor logic previously monkeypatched out
natritmeyer · Apr 10, 2018 · 0eec966 · 0eec966
1 parent 8a3cb48
commit 0eec966
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/features/step_definitions/navigation_steps.rb b/features/step_definitions/navigation_steps.rb
@@ -51,3 +51,7 @@
 Then(/^I will be redirected to the page without a title$/) do
   expect(@test_site.no_title).to be_displayed
 end
+
+When(/^I click the go button$/) do
+  @test_site.home.go_button.click
+end
diff --git a/features/waiting.feature b/features/waiting.feature
@@ -6,11 +6,11 @@ Feature: Waiting for Elements
   Scenario: Wait for Element - Positive
     When I navigate to the home page
     And I wait for the element that takes a while to appear
-    Then the element will appear
+    Then the slow element appears
 
   Scenario: Wait for Element - Negative
     When I navigate to the home page
-    And I wait for a specifically short amount of time for an element to appear
+    And I wait for a short amount of time for an element to appear
     Then the element I am waiting for doesn't appear in time
 
   Scenario: Wait for Visibility of element - Default Timeout
@@ -29,7 +29,7 @@ Feature: Waiting for Elements
 
   Scenario: Wait for Invisibility of element - Default Timeout
     When I navigate to the home page
-    And I wait while for an element to become invisible
+    And I wait for an element to become invisible
     Then the previously visible element is invisible
 
   Scenario: Wait for Invisibility of element - Overriden Timeout

diff --git a/test_site/pages/home_with_expected_elements.rb b/test_site/pages/home_with_expected_elements.rb
@@ -8,7 +8,7 @@ class TestHomePageWithExpectedElements < SitePrism::Page
   element :welcome_header, :xpath, '//h1'
   element :welcome_message, :xpath, '//span'
   element :go_button, :xpath, '//input'
-  element :link_to_search_page, :xpath, '//a'
+  element :link_to_search_page, :xpath, '//p[2]/a'
   element :some_slow_element, :xpath, '//a[@class="slow"]'
   element :invisible_element, 'input.invisible'
   element :shy_element, 'input#will_become_visible'

diff --git a/test_site/pages/no_title.rb b/test_site/pages/no_title.rb
@@ -2,6 +2,7 @@
 
 class TestNoTitle < SitePrism::Page
   set_url '/no_title.htm'
+  set_url_matcher(/no_title\.htm$/)
 
   element :element_without_selector
   elements :elements_without_selector