Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3910: Use entryTitle to display title in collection draft preview #1306

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Sep 26, 2024

Overview

What is the feature?

Collection draft preview doesn't display title after short name

What is the Solution?

In graphql query use entryTitle value for title

What areas of the application does this impact?

Collection draft preview

Testing

Collection draft preview should show title after short name

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@abbottry abbottry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (81eff52) to head (b8012d6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   97.52%   97.65%   +0.12%     
==========================================
  Files         362      362              
  Lines        5540     5584      +44     
  Branches     1155     1161       +6     
==========================================
+ Hits         5403     5453      +50     
+ Misses        136      130       -6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htranho
Copy link
Contributor Author

htranho commented Sep 27, 2024

Please add a test.

Done, test for entryTitle added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants