Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: chromatic noise models & feat: hypermodel empirical distributions #242

Open
wants to merge 168 commits into
base: master
Choose a base branch
from
Open

update: chromatic noise models & feat: hypermodel empirical distributions #242

wants to merge 168 commits into from

Conversation

jeremy-baier
Copy link

@jeremy-baier jeremy-baier commented Sep 8, 2024 •
edited
Loading

This PR contains many various updates associated with chromatic noise modeling efforts over the past several years.
Notable changes include:

  • functionality for “fixed-point” analysis where one can set a chromatic signal to a max likelihood value rather than sampling in that GPs hyperparameters.
  • the ability to sample in the chromatic index of a chromatic model.
  • it also expands functionality for empirical distributions to include a hypermodel empirical distribution.
  • cleans up the hypermodel code caching stuff which is called in each iteration unnecessarily
  • move the hypermodel weights to the lnPRIOR rather than the lnLIKELIHOOD (fixes issues with PTMCMC and hm weights)
  • prints hypermodel weights to a file in out directory (model_log_weights.json)
  • adds support for the SW GP basis & kernel from Nitu et al 2024

Hazboun6 and others added 30 commits March 2, 2020 22:15
@Hazboun6
Added sunssb calculatin to theta impact.
930aca4
@Hazboun6
Merge branch 'master' into jsh-solar_wind_models
5ac0875 
merge
@Hazboun6
added to theta_impact docstring
eb3a5fe
@Hazboun6
Added sunssb arg to functions.
0107bc2
@Hazboun6
Added sunssb arg to solar_wind
692d227
@Hazboun6
Added sunssb arg to create_fourier_designmatrix_sw
c2d6db4
@Hazboun6
Added dm_solar_wind_r_to_p
957fb2f
@Hazboun6
Added flag to be able to use log10_ne
5a9b275
@Hazboun6
Merge branch 'master' into jsh-solar_wind_models
efd7883 
merging master in
@Hazboun6
Added flag to model2a, model3a, modelgen to turn off rn model.
4e3987d
@Hazboun6
Merged with master.
f1b5270
@Hazboun6
Merged with master 2.
ab8a118
@Hazboun6
Added option for dropout of intrinsic red noise.
ac7f846
@Hazboun6
Added dropout params to docstring
11ce811
@Hazboun6
Merging in recent master branch changes.
15a2e57
@Hazboun6
More merging
52b6146
@Hazboun6
More merging
f6786c8
@Hazboun6
More merging
31d0d0d
@Hazboun6
No changes.
c27e0f6
@Hazboun6
space deletion
8473114
@Hazboun6
Tweaks to WN model for CHIME ECORR
ea4ae02
Adding option to set dt for linear_interp_basis in single_pulsar_mode…
96b1b1d 
…l for dm_gp and chrom_gp
Fixed syntax
0018aae
@Hazboun6
Merge pull request nanograv#5 from josephjsimon/jjs-test
a4b8db0 
Adding option to set dt
@Hazboun6
Update binned sw model.
fc40557
@Hazboun6
Update binned sw model 2.
ef10544
@Hazboun6
Update binned sw model 3.
ea6c173
@Hazboun6
Update binned sw model 4.
f94a09c
@Hazboun6
Update binned sw model 5.
263b88b
@Hazboun6
Update binned sw model 6.
b0b45a7
@Hazboun6
Copy link
Member

@AaronDJohnson do you recognize the errors that are happening in the mac installs? It's a libstempo issue, so it doesn't even get to the actual unit tests.

@blarsen10
Copy link

This also now adds support for the SW GP basis & kernel from Nitu et al 2024

@Hazboun6
Copy link
Member

@blarsen10 and @jeremy-baier Can we have a look at the errors here ASAP. From what I saw it's just not passing the linting rules. It would be good to get this merged this week.

@Hazboun6
Copy link
Member

@jeremy-baier and @blarsen10 I think that the reason the tests are still failing is that GitHub CI uses the setup.py to setup the environment for the tests. That doesn't limit the scipy version yet.

Hazboun6 and others added 2 commits September 19, 2024 21:50
@jeremy-baier jeremy-baier mentioned this pull request Oct 21, 2024
Open
13 tasks
@AaronDJohnson
Copy link
Collaborator

@AaronDJohnson do you recognize the errors that are happening in the mac installs? It's a libstempo issue, so it doesn't even get to the actual unit tests.

Sorry for the delay on all of this. Feel free to ping me again if you don't get a reply quickly next time! I did know exactly what was happening, and I've merged a fix. If @jeremy-baier pulls from upstream/main, the Mac tests should be fixed now. The new runners only support ARM architectures, so we have to go back one version on the CI runners so that they run an x86 architecture instead.

@AaronDJohnson
Copy link
Collaborator

I've also fixed the scipy issue by updating to the new recommended function. So you can remove the maximum version number on scipy here.

@jeremy-baier jeremy-baier changed the title Chromatic noise updates update: chromatic noise models & feat: hypermodel empirical distributions Jan 10, 2025
@jeremy-baier jeremy-baier mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremy-baier @Hazboun6 @blarsen10 @AaronDJohnson