Re-enable running our eslint rules using ts-node (microsoft#159495)

Resubmission of microsoft#157532 with the following changes: - Use `eslint-plugin-local` instead of `yarn` link to run our plugins - Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`) - Update all names to `local/`
mwadams · Aug 30, 2022 · 5e92794 · 5e92794
1 parent 3e44e34
commit 5e92794
Show file tree

Hide file tree

Showing 60 changed files with 240 additions and 1,401 deletions.
diff --git a/build/lib/eslint/code-import-patterns.ts → .eslintplugin/code-import-patterns.ts b/build/lib/eslint/code-import-patterns.ts → .eslintplugin/code-import-patterns.ts
@@ -6,10 +6,10 @@
 import * as eslint from 'eslint';
 import { TSESTree } from '@typescript-eslint/experimental-utils';
 import * as path from 'path';
-import * as minimatch from 'minimatch';
+import minimatch from 'minimatch';
 import { createImportRuleListener } from './utils';
 
-const REPO_ROOT = path.normalize(path.join(__dirname, '../../../'));
+const REPO_ROOT = path.normalize(path.join(__dirname, '../'));
 
 interface ConditionalPattern {
 	when?: 'hasBrowser' | 'hasNode' | 'test';

diff --git a/build/lib/eslint/code-layering.ts → .eslintplugin/code-layering.ts b/build/lib/eslint/code-layering.ts → .eslintplugin/code-layering.ts
diff --git a/...d/lib/eslint/code-no-look-behind-regex.ts → .eslintplugin/code-no-look-behind-regex.ts b/...d/lib/eslint/code-no-look-behind-regex.ts → .eslintplugin/code-no-look-behind-regex.ts
diff --git a/...slint/code-no-nls-in-standalone-editor.ts → ...lugin/code-no-nls-in-standalone-editor.ts b/...slint/code-no-nls-in-standalone-editor.ts → ...lugin/code-no-nls-in-standalone-editor.ts
diff --git a/...d/lib/eslint/code-no-standalone-editor.ts → .eslintplugin/code-no-standalone-editor.ts b/...d/lib/eslint/code-no-standalone-editor.ts → .eslintplugin/code-no-standalone-editor.ts
diff --git a/build/lib/eslint/code-no-test-only.ts → .eslintplugin/code-no-test-only.ts b/build/lib/eslint/code-no-test-only.ts → .eslintplugin/code-no-test-only.ts
diff --git a/.../eslint/code-no-unexternalized-strings.ts → ...tplugin/code-no-unexternalized-strings.ts b/.../eslint/code-no-unexternalized-strings.ts → ...tplugin/code-no-unexternalized-strings.ts
diff --git a/.../lib/eslint/code-no-unused-expressions.ts → .eslintplugin/code-no-unused-expressions.ts b/.../lib/eslint/code-no-unused-expressions.ts → .eslintplugin/code-no-unused-expressions.ts
diff --git a/build/lib/eslint/code-translation-remind.ts → .eslintplugin/code-translation-remind.ts b/build/lib/eslint/code-translation-remind.ts → .eslintplugin/code-translation-remind.ts
diff --git a/.eslintplugin/index.js b/.eslintplugin/index.js
@@ -0,0 +1,12 @@
+const glob = require('glob');
+const path = require('path');
+
+require('ts-node').register({ experimentalResolver: true, transpileOnly: true });
+
+// Re-export all .ts files as rules
+const rules = {};
+glob.sync(`${__dirname}/*.ts`).forEach((file) => {
+	rules[path.basename(file, '.ts')] = require(file);
+});
+
+exports.rules = rules;
diff --git a/.eslintplugin/tsconfig.json b/.eslintplugin/tsconfig.json
@@ -0,0 +1,26 @@
+{
+	"compilerOptions": {
+		"target": "es2020",
+		"lib": [
+			"ES2020"
+		],
+		"module": "commonjs",
+		"esModuleInterop": true,
+		"alwaysStrict": true,
+		"allowJs": true,
+		"strict": true,
+		"exactOptionalPropertyTypes": false,
+		"useUnknownInCatchVariables": false,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
+		"newLine": "lf",
+		"noEmit": true
+	},
+	"include": [
+		"**/*.ts",
+		"**/*.js"
+	],
+	"exclude": [
+		"node_modules/**"
+	]
+}
diff --git a/build/lib/eslint/utils.ts → .eslintplugin/utils.ts b/build/lib/eslint/utils.ts → .eslintplugin/utils.ts
diff --git a/build/lib/eslint/vscode-dts-cancellation.ts → .eslintplugin/vscode-dts-cancellation.ts b/build/lib/eslint/vscode-dts-cancellation.ts → .eslintplugin/vscode-dts-cancellation.ts
diff --git a/build/lib/eslint/vscode-dts-create-func.ts → .eslintplugin/vscode-dts-create-func.ts b/build/lib/eslint/vscode-dts-create-func.ts → .eslintplugin/vscode-dts-create-func.ts
diff --git a/build/lib/eslint/vscode-dts-event-naming.ts → .eslintplugin/vscode-dts-event-naming.ts b/build/lib/eslint/vscode-dts-event-naming.ts → .eslintplugin/vscode-dts-event-naming.ts
diff --git a/...lib/eslint/vscode-dts-interface-naming.ts → .eslintplugin/vscode-dts-interface-naming.ts b/...lib/eslint/vscode-dts-interface-naming.ts → .eslintplugin/vscode-dts-interface-naming.ts
diff --git a/...lib/eslint/vscode-dts-literal-or-types.ts → .eslintplugin/vscode-dts-literal-or-types.ts b/...lib/eslint/vscode-dts-literal-or-types.ts → .eslintplugin/vscode-dts-literal-or-types.ts
diff --git a/.../lib/eslint/vscode-dts-provider-naming.ts → .eslintplugin/vscode-dts-provider-naming.ts b/.../lib/eslint/vscode-dts-provider-naming.ts → .eslintplugin/vscode-dts-provider-naming.ts
diff --git a/.../lib/eslint/vscode-dts-region-comments.ts → .eslintplugin/vscode-dts-region-comments.ts b/.../lib/eslint/vscode-dts-region-comments.ts → .eslintplugin/vscode-dts-region-comments.ts
diff --git a/build/lib/eslint/vscode-dts-use-thenable.ts → .eslintplugin/vscode-dts-use-thenable.ts b/build/lib/eslint/vscode-dts-use-thenable.ts → .eslintplugin/vscode-dts-use-thenable.ts
diff --git a/...b/eslint/vscode-dts-vscode-in-comments.ts → ...ntplugin/vscode-dts-vscode-in-comments.ts b/...b/eslint/vscode-dts-vscode-in-comments.ts → ...ntplugin/vscode-dts-vscode-in-comments.ts
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -8,7 +8,8 @@
 	"plugins": [
 		"@typescript-eslint",
 		"jsdoc",
-		"header"
+		"header",
+		"local"
 	],
 	"rules": {
 		"constructor-super": "warn",
@@ -61,17 +62,17 @@
 				]
 			}
 		],
-		"code-no-unused-expressions": [
+		"local/code-no-unused-expressions": [
 			"warn",
 			{
 				"allowTernary": true
 			}
 		],
-		"code-translation-remind": "warn",
-		"code-no-nls-in-standalone-editor": "warn",
-		"code-no-standalone-editor": "warn",
-		"code-no-unexternalized-strings": "warn",
-		"code-layering": [
+		"local/code-translation-remind": "warn",
+		"local/code-no-nls-in-standalone-editor": "warn",
+		"local/code-no-standalone-editor": "warn",
+		"local/code-no-unexternalized-strings": "warn",
+		"local/code-layering": [
 			"warn",
 			{
 				"common": [],
@@ -122,8 +123,8 @@
 				"**/*.test.ts"
 			],
 			"rules": {
-				"code-no-test-only": "error",
-				"code-no-unexternalized-strings": "off"
+				"local/code-no-test-only": "error",
+				"local/code-no-unexternalized-strings": "off"
 			}
 		},
 		{
@@ -132,14 +133,14 @@
 				"**/vscode.proposed.*.d.ts"
 			],
 			"rules": {
-				"vscode-dts-create-func": "warn",
-				"vscode-dts-literal-or-types": "warn",
-				"vscode-dts-interface-naming": "warn",
-				"vscode-dts-cancellation": "warn",
-				"vscode-dts-use-thenable": "warn",
-				"vscode-dts-region-comments": "warn",
-				"vscode-dts-vscode-in-comments": "warn",
-				"vscode-dts-provider-naming": [
+				"local/vscode-dts-create-func": "warn",
+				"local/vscode-dts-literal-or-types": "warn",
+				"local/vscode-dts-interface-naming": "warn",
+				"local/vscode-dts-cancellation": "warn",
+				"local/vscode-dts-use-thenable": "warn",
+				"local/vscode-dts-region-comments": "warn",
+				"local/vscode-dts-vscode-in-comments": "warn",
+				"local/vscode-dts-provider-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -154,7 +155,7 @@
 						]
 					}
 				],
-				"vscode-dts-event-naming": [
+				"local/vscode-dts-event-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -200,8 +201,8 @@
 				"src/**/*.ts"
 			],
 			"rules": {
-				"code-no-look-behind-regex": "warn",
-				"code-import-patterns": [
+				"local/code-no-look-behind-regex": "warn",
+				"local/code-import-patterns": [
 					"warn",
 					{
 						// imports that are allowed in all files of layers:
@@ -576,7 +577,7 @@
 				"test/**/*.ts"
 			],
 			"rules": {
-				"code-import-patterns": [
+				"local/code-import-patterns": [
 					"warn",
 					{
 						"target": "test/smoke/**",

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -41,11 +41,6 @@
 			}
 		}
 	],
-	"eslint.options": {
-		"rulePaths": [
-			"./build/lib/eslint"
-		]
-	},
 	"typescript.tsdk": "node_modules/typescript/lib",
 	"npm.exclude": "**/extensions/**",
 	"npm.packageManager": "yarn",

diff --git a/build/eslint.js b/build/eslint.js
@@ -13,8 +13,7 @@ function eslint() {
 		.src(eslintFilter, { base: '.', follow: true, allowEmpty: true })
 		.pipe(
 			gulpeslint({
-				configFile: '.eslintrc.json',
-				rulePaths: ['./build/lib/eslint'],
+				configFile: '.eslintrc.json'
 			})
 		)
 		.pipe(gulpeslint.formatEach('compact'))

diff --git a/build/hygiene.js b/build/hygiene.js
@@ -173,8 +173,7 @@ function hygiene(some, linting = true) {
 				.pipe(filter(eslintFilter))
 				.pipe(
 					gulpeslint({
-						configFile: '.eslintrc.json',
-						rulePaths: ['./build/lib/eslint'],
+						configFile: '.eslintrc.json'
 					})
 				)
 				.pipe(gulpeslint.formatEach('compact'))

diff --git a/build/lib/eslint/code-import-patterns.js b/build/lib/eslint/code-import-patterns.js