Popover: fix #1285 bug #1425
Open
Popover: fix #1285 bug #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 30.18% 30.24% +0.05%
==========================================
Files 220 220
Lines 3578 3581 +3
Branches 749 750 +1
==========================================
+ Hits 1080 1083 +3
Misses 1880 1880
Partials 618 618
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
My PR fixes memory leak errors that exist in components that use the Popover component with the Scroll directive.
Many event listeners were registered, but the target element did not change.
This problem we can see on https://muse-ui.org/#/en-US/select using Memory Chrome DevTools.