Prefer string interpolation to string concatenation

murugaperumal-ramasamy · Feb 4, 2023 · a7b740e · a7b740e
1 parent 4011404
commit a7b740e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/twitter/streaming/client.rb b/lib/twitter/streaming/client.rb
@@ -114,7 +114,7 @@ def close
       def request(method, uri, params)
         before_request.call
         headers = Twitter::Headers.new(self, method, uri, params).request_headers
-        request = HTTP::Request.new(verb: method, uri: uri + '?' + to_url_params(params), headers: headers, proxy: proxy)
+        request = HTTP::Request.new(verb: method, uri: "#{uri}?#{to_url_params(params)}", headers: headers, proxy: proxy)
         response = Streaming::Response.new do |data|
           if item = Streaming::MessageParser.parse(data) # rubocop:disable Lint/AssignmentInCondition
             yield(item)

diff --git a/spec/helper.rb b/spec/helper.rb
@@ -63,7 +63,7 @@ def fixture_path
 end
 
 def fixture(file)
-  File.new(fixture_path + '/' + file)
+  File.new("#{fixture_path}/#{file}")
 end
 
 def capture_warning

diff --git a/spec/twitter/headers_spec.rb b/spec/twitter/headers_spec.rb
@@ -3,7 +3,7 @@
 describe Twitter::Headers do
   before do
     @client = Twitter::REST::Client.new(consumer_key: 'CK', consumer_secret: 'CS', access_token: 'AT', access_token_secret: 'AS')
-    @headers = Twitter::Headers.new(@client, :get, Twitter::REST::Request::BASE_URL + '/path')
+    @headers = Twitter::Headers.new(@client, :get, "#{Twitter::REST::Request::BASE_URL}/path")
   end
 
   describe '#oauth_auth_header' do
@@ -40,7 +40,7 @@
   describe '#bearer_auth_header' do
     it 'creates the correct auth headers with supplied bearer token' do
       client = Twitter::REST::Client.new(bearer_token: 'BT')
-      headers = Twitter::Headers.new(client, :get, Twitter::REST::Request::BASE_URL + '/path')
+      headers = Twitter::Headers.new(client, :get, "#{Twitter::REST::Request::BASE_URL}/path")
       authorization = headers.send(:bearer_auth_header)
       expect(authorization).to eq('Bearer BT')
     end