Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve getReactElementRef() utils #43022

Merged
merged 14 commits into from
Sep 19, 2024
Merged

[core] Improve getReactElementRef() utils #43022

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
62e5726
move logic
sai6855 Aug 9, 2024
b7ea8dd
fix types
sai6855 Aug 9, 2024
aecd27a
modify logic according to https://github.com/mui/material-ui/pull/430…
sai6855 Sep 15, 2024
43b4ef6
Rename folder
aarongarciah Sep 19, 2024
009ad13
Rename utility function
aarongarciah Sep 19, 2024
c14f907
update file names
sai6855 Sep 15, 2024
25d3e9d
pnpm prettier
sai6855 Sep 15, 2024
7bc2059
update logic
sai6855 Sep 15, 2024
68ee1e7
remove error code
sai6855 Sep 15, 2024
170f6ae
update portal logic
sai6855 Sep 15, 2024
ca2d271
trigger
sai6855 Sep 15, 2024
2852483
check for react version instead of using propertyIsEnumerable
sai6855 Sep 19, 2024
abe26e2
update return type
sai6855 Sep 19, 2024
b84c85d
use parseInt instead of split
sai6855 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use parseInt instead of split
  • Loading branch information
@sai6855 @aarongarciah
sai6855 authored and aarongarciah committed Sep 19, 2024
commit b84c85d34ea6d0495ca3703f3fb0312f7f387415
4 changes: 1 addition & 3 deletions packages/mui-utils/src/getReactElementRef/getReactElementRef.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ import * as React from 'react';
export default function getReactElementRef(
element: React.ReactElement,
): React.Ref<any> | null | undefined {
const reactMajorVersion = parseInt(React.version.split('.')[0], 10);

// 'ref' is passed as prop in React 19, whereas 'ref' is directly attached to children in older versions
if (reactMajorVersion >= 19) {
if (parseInt(React.version, 10) >= 19) {
return element.props?.ref;
}
// @ts-expect-error element.ref is not included in the ReactElement type
Expand Down
Loading