Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Dark mode toggle doesn't affect [data-mui-color-scheme] #38575

Open
michaldudak opened this issue Aug 21, 2023 · 2 comments · May be fixed by #39077
Open

[website] Dark mode toggle doesn't affect [data-mui-color-scheme] #38575

michaldudak opened this issue Aug 21, 2023 · 2 comments · May be fixed by #39077
Assignees
@siriwatknp
Labels
bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused.

Comments

@michaldudak
Copy link
Member

The dark mode toggle in the components docs does not change the value of the data-mui-color-scheme attribute on the <html> element. This causes the Tailwind demos to be styled incorrectly.

See https://mui.com/base-ui/react-input/#basics: switch to Tailwind CSS and change the display mode.

image
@michaldudak michaldudak added bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused. labels Aug 21, 2023
@michaldudak michaldudak mentioned this issue Aug 21, 2023
Merged
@sai6855 sai6855 mentioned this issue Sep 19, 2023
Closed
@anle9650 anle9650 mentioned this issue Sep 20, 2023
Closed
1 task
@ttlpta ttlpta linked a pull request Sep 20, 2023 that will close this issue
Open
1 task
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 20, 2023 •
edited
Loading

We can see the same bug on https://master--material-ui.netlify.app/material-ui/experimental-api/css-theme-variables/usage/#getting-started dark/light switch.

@zanivan zanivan mentioned this issue Oct 19, 2023
Merged
1 task
@zanivan
Copy link
Contributor

zanivan commented Dec 4, 2023 •
edited
Loading

Spotted another case of this on the landing page. I reckon we should look into this issue before the stable release—otherwise, it'll be bad to have a bug being showcased in the LP when we go stable 😬

Screenshot 2023-12-04 at 09 09 00

@danilo-leal danilo-leal mentioned this issue Dec 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
4 participants
@oliviertassinari @michaldudak @siriwatknp @zanivan