Added Open With apps for macOS - addressed PR review

mucommander · May 15, 2023 · 6e8bbf3 · 6e8bbf3
1 parent f83b204
commit 6e8bbf3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/mucommander-core/src/main/java/com/mucommander/ui/main/menu/OpenWithMenu.java b/mucommander-core/src/main/java/com/mucommander/ui/main/menu/OpenWithMenu.java
@@ -124,7 +124,7 @@ private void populate() {
                 }).start();
             } else {
                 if (DesktopManager.canEnableOpenWithApps()) {
-                    if (getItemCount() > 1) {
+                    if (getItemCount() > 0) {
                         add(new JSeparator());
                     }
                     var howToEnable = super.add(

diff --git a/mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java b/mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java
@@ -93,7 +93,7 @@ public class OSXDesktopAdapter extends DefaultDesktopAdapter {
     private static final String DEFAULT_SHELL_INTERACTIVE = "--login";
 
     // cached values
-    private String dutiCmdPath = null;
+    private String dutiCmdPath;
 
     private Map<String, String> utiForExt = createSizeLimitedMap(200);
 
@@ -450,9 +450,10 @@ private String getPathOfDutiCmd() {
             }
             return false;       // continue searching
         });
-        if (dutiCmdPath != null && dutiCmdPath.length() > 0) {
+        if (dutiCmdPath != null && !dutiCmdPath.isEmpty()) {
             LOGGER.info("Command 'duti' found here: {}", dutiCmdPath);
         } else {
+            dutiCmdPath = null; // nullify if was empty
             LOGGER.error("Command 'duti' not found");
         }
         return dutiCmdPath;